darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-05 02:41:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Removing total_notification calculations.

Browse Source 
Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>
This commit is contained in:
Cliff Hill
2025-01-10 16:52:30 -05:00
parent 467357c031
commit 3f8c49d829
3 changed files with 6 additions and 67 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
app/service/statistics.py
View File

@@ -5,13 +5,12 @@ from app.dao.date_util import get_months_for_financial_year
from app.enums import (
KeyType,
NotificationStatus,
NotificationType,
StatisticsType,
TemplateType,
)
def format_statistics(statistics, total_notifications=None):
def format_statistics(statistics):
# statistics come in a named tuple with uniqueness from 'notification_type', 'status' - however missing
# statuses/notification types won't be represented and the status types need to be simplified/summed up
# so we can return emails/sms * created, sent, and failed
@@ -25,17 +24,6 @@ def format_statistics(statistics, total_notifications=None):
row,
)
# Update pending count directly
if NotificationType.SMS in counts and total_notifications is not None:
sms_dict = counts[NotificationType.SMS]
requested_count = sms_dict[StatisticsType.REQUESTED]
delivered_count = sms_dict[StatisticsType.DELIVERED]
failed_count = sms_dict[StatisticsType.FAILURE]
pending_count = total_notifications - (
requested_count + delivered_count + failed_count
)
sms_dict[StatisticsType.PENDING] = pending_count
return counts