darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 09:26:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add a task to save-api-sms for high volume services.

Browse Source 
When we initially added a new task to persist the notifications for a high volume service we wanted to implement it as quickly as possible, so ignored SMS.
This will allow a high volume service to send SMS, the SMS will be sent to a queue to then persist and send the SMS, similar to emails.

At this point I haven't added a new application to consume the new save-api-sms-tasks. But we can add a separate application or be happy with how the app scales for both email and sms.
This commit is contained in:
Rebecca Law
2020-10-19 13:29:05 +01:00
parent d9ceed55b5
commit 3dee4ad310
7 changed files with 126 additions and 76 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
tests/app/v2/notifications/test_post_notifications.py
View File

@@ -1029,12 +1029,44 @@ def test_post_email_notification_when_data_is_empty_returns_400(client, sample_s
assert error_msg == 'email_address is a required property'
def test_post_notifications_saves_sms_to_queue(client, notify_db_session, mocker):
save_task = mocker.patch("app.celery.tasks.save_api_sms.apply_async")
mock_send_task = mocker.patch('app.celery.provider_tasks.deliver_sms.apply_async')
service = create_service(
service_id=current_app.config['HIGH_VOLUME_SERVICE'][0],
service_name=f'high volume service',
)
template = create_template(service=service, content='((message))')
data = {
"phone_number": "+447700900855",
"template_id": template.id,
"personalisation": {"message": "Dear citizen, have a nice day"}
}
response = client.post(
path=f'/v2/notifications/sms',
data=json.dumps(data),
headers=[('Content-Type', 'application/json'), create_authorization_header(service_id=service.id)]
)
json_resp = response.get_json()
assert response.status_code == 201
assert json_resp['id']
assert json_resp['content']['body'] == "Dear citizen, have a nice day"
assert json_resp['template']['id'] == str(template.id)
save_task.assert_called_once_with([mock.ANY], queue='save-api-sms-tasks')
assert not mock_send_task.called
assert len(Notification.query.all()) == 0
def test_post_notifications_saves_email_to_queue(client, notify_db_session, mocker):
save_email_task = mocker.patch("app.celery.tasks.save_api_email.apply_async")
mock_send_task = mocker.patch('app.celery.provider_tasks.deliver_email.apply_async')
service = create_service(
service_id=current_app.config['HIGH_VOLUME_SERVICE'][0],
service_id=current_app.config['HIGH_VOLUME_SERVICE'][1],
service_name='high volume service',
)
template = create_template(service=service, content='((message))', template_type=EMAIL_TYPE)
@@ -1068,7 +1100,7 @@ def test_post_notifications_saves_email_normally_if_save_email_to_queue_fails(cl
mock_send_task = mocker.patch('app.celery.provider_tasks.deliver_email.apply_async')
service = create_service(
service_id=current_app.config['HIGH_VOLUME_SERVICE'][1],
service_id=current_app.config['HIGH_VOLUME_SERVICE'][2],
service_name='high volume service',
)
template = create_template(service=service, content='((message))', template_type=EMAIL_TYPE)
@@ -1100,7 +1132,7 @@ def test_post_notifications_doesnt_save_email_to_queue_for_test_emails(client, n
mock_send_task = mocker.patch('app.celery.provider_tasks.deliver_email.apply_async')
service = create_service(
service_id=current_app.config['HIGH_VOLUME_SERVICE'][2],
service_id=current_app.config['HIGH_VOLUME_SERVICE'][3],
service_name='high volume service',
)
template = create_template(service=service, content='((message))', template_type=EMAIL_TYPE)
@@ -1125,33 +1157,3 @@ def test_post_notifications_doesnt_save_email_to_queue_for_test_emails(client, n
assert mock_send_task.called
assert not save_email_task.called
assert len(Notification.query.all()) == 1
def test_post_notifications_doesnt_save_email_to_queue_for_sms(client, notify_db_session, mocker):
save_email_task = mocker.patch("app.celery.tasks.save_api_email.apply_async")
mock_send_task = mocker.patch('app.celery.provider_tasks.deliver_sms.apply_async')
service = create_service(
service_id=current_app.config['HIGH_VOLUME_SERVICE'][3],
service_name='high volume service',
)
template = create_template(service=service, content='((message))', template_type=SMS_TYPE)
data = {
"phone_number": '+447700900855',
"template_id": template.id,
"personalisation": {"message": "Dear citizen, have a nice day"}
}
response = client.post(
path='/v2/notifications/sms',
data=json.dumps(data),
headers=[('Content-Type', 'application/json'), create_authorization_header(service_id=service.id)]
)
json_resp = response.get_json()
assert response.status_code == 201
assert json_resp['id']
assert mock_send_task.called
assert not save_email_task.called
assert len(Notification.query.all()) == 1