From 3cfeadcae873b6e45c73d3b637dff256d190ad12 Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Mon, 3 Dec 2018 11:33:59 +0000 Subject: [PATCH] Refactor if statement to be positive --- app/service/send_notification.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/service/send_notification.py b/app/service/send_notification.py index 62e61283c..a00d151a4 100644 --- a/app/service/send_notification.py +++ b/app/service/send_notification.py @@ -39,9 +39,9 @@ def validate_created_by(service, created_by_id): def create_one_off_reference(template_type): - if template_type != LETTER_TYPE: - return None - return create_random_identifier() + if template_type == LETTER_TYPE: + return create_random_identifier() + return None def send_one_off_notification(service_id, post_data):