Clean up and validate low static-scan findings

2026-08-20 14:29:25 -04:00 · 2022-08-19 14:32:11 +00:00
parent 53f2519c2a
commit 3c035531aa
6 changed files with 13 additions and 12 deletions
--- a/app/commands.py
+++ b/app/commands.py
@@ -544,7 +544,8 @@ def populate_organisation_agreement_details_from_file(file_name):

            current_app.logger.info(f"Updating {org.name}")

-            assert org.agreement_signed
+            if not org.agreement_signed:
+                raise RuntimeError('Agreement was not signed')

            org.agreement_signed_version = float(row[1])
            org.agreement_signed_on_behalf_of_name = row[2].strip()