darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-16 10:12:32 -05:00
Code Issues Packages Projects Releases Wiki Activity

Improve the logging message

Browse Source
This commit is contained in:
Rebecca Law
2016-07-01 14:42:40 +01:00
parent f52755742c
commit 3aff22cf87
2 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/celery/provider_tasks.py
View File

@@ -95,7 +95,7 @@ def send_sms_to_provider(self, service_id, notification_id):
update_notification_status_by_id(notification.id, 'technical-failure', 'failure') update_notification_status_by_id(notification.id, 'technical-failure', 'failure')
current_app.logger.info( current_app.logger.info(
"SMS {} sent at {}".format(notification_id, notification.sent_at) "SMS {} sent to provider at {}".format(notification_id, notification.sent_at)
) )
statsd_client.incr("notifications.tasks.send-sms-to-provider") statsd_client.incr("notifications.tasks.send-sms-to-provider")
statsd_client.timing("notifications.tasks.send-sms-to-provider.task-time", monotonic() - task_start) statsd_client.timing("notifications.tasks.send-sms-to-provider.task-time", monotonic() - task_start)
@@ -167,7 +167,7 @@ def send_email_to_provider(self, service_id, notification_id, reply_to_addresses
update_notification_status_by_id(notification.id, 'technical-failure', 'failure') update_notification_status_by_id(notification.id, 'technical-failure', 'failure')
current_app.logger.info( current_app.logger.info(
"Email {} created at {} sent at {}".format(notification_id, notification.created_at, notification.sent_at) "Email {} sent to provider at {}".format(notification_id, notification.sent_at)
) )
statsd_client.incr("notifications.tasks.send-email-to-provider") statsd_client.incr("notifications.tasks.send-email-to-provider")
statsd_client.timing("notifications.tasks.send-email-to-provider.task-time", monotonic() - task_start) statsd_client.timing("notifications.tasks.send-email-to-provider.task-time", monotonic() - task_start)

6
app/celery/tasks.py
View File

@@ -162,12 +162,8 @@ def send_email(self, service_id, notification_id, encrypted_notification, create
notification = encryption.decrypt(encrypted_notification) notification = encryption.decrypt(encrypted_notification)
service = dao_fetch_service_by_id(service_id) service = dao_fetch_service_by_id(service_id)
provider = provider_to_use(EMAIL_TYPE, notification_id)
if not service_allowed_to_send_to(notification['to'], service): if not service_allowed_to_send_to(notification['to'], service):
current_app.logger.info( current_app.logger.info("Email {} failed as restricted service".format(notification_id))
"Email {} failed as restricted service".format(notification_id)
)
return return
try: try: