mirror of
https://github.com/GSA/notifications-api.git
synced 2026-02-02 09:26:08 -05:00
try to fix test code
This commit is contained in:
@@ -3,6 +3,7 @@ from datetime import timedelta
|
||||
|
||||
import pytest
|
||||
from freezegun import freeze_time
|
||||
from sqlalchemy import func, select
|
||||
from sqlalchemy.exc import DataError
|
||||
from sqlalchemy.orm.exc import NoResultFound
|
||||
|
||||
@@ -55,8 +56,10 @@ def test_create_user(notify_db_session, phone_number, expected_phone_number):
|
||||
}
|
||||
user = User(**data)
|
||||
save_model_user(user, password="password", validated_email_access=True)
|
||||
assert User.query.count() == 1
|
||||
user_query = User.query.first()
|
||||
stmt = select(func.count(User.id))
|
||||
assert db.session.execute(stmt).scalar() == 1
|
||||
stmt = select(User)
|
||||
user_query = db.session.execute(stmt).scalars().first()
|
||||
assert user_query.email_address == email
|
||||
assert user_query.id == user.id
|
||||
assert user_query.mobile_number == expected_phone_number
|
||||
@@ -68,7 +71,8 @@ def test_get_all_users(notify_db_session):
|
||||
create_user(email="1@test.com")
|
||||
create_user(email="2@test.com")
|
||||
|
||||
assert User.query.count() == 2
|
||||
stmt = select(func.count(User.id))
|
||||
assert db.session.execute(stmt).scalar() == 2
|
||||
assert len(get_user_by_id()) == 2
|
||||
|
||||
|
||||
@@ -89,9 +93,10 @@ def test_get_user_invalid_id(notify_db_session):
|
||||
|
||||
|
||||
def test_delete_users(sample_user):
|
||||
assert User.query.count() == 1
|
||||
stmt = select(func.count(User.id))
|
||||
assert db.session.execute(stmt).scalar() == 1
|
||||
delete_model_user(sample_user)
|
||||
assert User.query.count() == 0
|
||||
assert db.session.execute(stmt).scalar() == 0
|
||||
|
||||
|
||||
def test_increment_failed_login_should_increment_failed_logins(sample_user):
|
||||
@@ -127,9 +132,10 @@ def test_get_user_by_email_is_case_insensitive(sample_user):
|
||||
def test_should_delete_all_verification_codes_more_than_one_day_old(sample_user):
|
||||
make_verify_code(sample_user, age=timedelta(hours=24), code="54321")
|
||||
make_verify_code(sample_user, age=timedelta(hours=24), code="54321")
|
||||
assert VerifyCode.query.count() == 2
|
||||
stmt = select(func.count(VerifyCode.id))
|
||||
assert db.session.execute(stmt).scalar() == 2
|
||||
delete_codes_older_created_more_than_a_day_ago()
|
||||
assert VerifyCode.query.count() == 0
|
||||
assert db.session.execute(stmt).scalar() == 0
|
||||
|
||||
|
||||
def test_should_not_delete_verification_codes_less_than_one_day_old(sample_user):
|
||||
@@ -137,10 +143,11 @@ def test_should_not_delete_verification_codes_less_than_one_day_old(sample_user)
|
||||
sample_user, age=timedelta(hours=23, minutes=59, seconds=59), code="12345"
|
||||
)
|
||||
make_verify_code(sample_user, age=timedelta(hours=24), code="54321")
|
||||
|
||||
assert VerifyCode.query.count() == 2
|
||||
stmt = select(func.count(VerifyCode))
|
||||
assert db.session.execute(stmt).scalar() == 2
|
||||
delete_codes_older_created_more_than_a_day_ago()
|
||||
assert VerifyCode.query.one()._code == "12345"
|
||||
stmt = select(VerifyCode)
|
||||
assert db.session.execute(stmt).scalars().one()._code == "12345"
|
||||
|
||||
|
||||
def make_verify_code(user, age=None, expiry_age=None, code="12335", code_used=False):
|
||||
|
||||
Reference in New Issue
Block a user