Made enums.py for all the enums to avoid cyclic imports.

Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>

app/notifications/process_notifications.py

@@ -16,12 +16,8 @@ from app.dao.notifications_dao import (
     dao_create_notification,
     dao_delete_notifications_by_id,
 )
-from app.models import (
-    KEY_TYPE_TEST,
-    NOTIFICATION_CREATED,
-    Notification,
-    NotificationType,
-)
+from app.enums import NotificationType
+from app.models import KEY_TYPE_TEST, NOTIFICATION_CREATED, Notification
 from app.v2.errors import BadRequestError
 
 

app/notifications/rest.py

@@ -4,8 +4,9 @@ from notifications_utils import SMS_CHAR_COUNT_LIMIT
 from app import api_user, authenticated_service
 from app.config import QueueNames
 from app.dao import notifications_dao
+from app.enums import NotificationType
 from app.errors import InvalidRequest, register_errors
-from app.models import KEY_TYPE_TEAM, PRIORITY, NotificationType
+from app.models import KEY_TYPE_TEAM, PRIORITY
 from app.notifications.process_notifications import (
     persist_notification,
     send_notification_to_queue,

app/notifications/validators.py

@@ -15,14 +15,8 @@ from app import redis_store
 from app.dao.notifications_dao import dao_get_notification_count_for_service
 from app.dao.service_email_reply_to_dao import dao_get_reply_to_by_id
 from app.dao.service_sms_sender_dao import dao_get_service_sms_senders_by_id
-from app.models import (
-    KEY_TYPE_TEAM,
-    KEY_TYPE_TEST,
-    NotificationType,
-    ServicePermission,
-    ServicePermissionType,
-    TemplateType,
-)
+from app.enums import NotificationType, ServicePermissionType, TemplateType
+from app.models import KEY_TYPE_TEAM, KEY_TYPE_TEST, ServicePermission
 from app.notifications.process_notifications import create_content_for_notification
 from app.serialised_models import SerialisedTemplate
 from app.service.utils import service_allowed_to_send_to