Made enums.py for all the enums to avoid cyclic imports.

Signed-off-by: Cliff Hill <Clifford.hill@gsa.gov>

app/celery/nightly_tasks.py

@@ -25,7 +25,8 @@ from app.dao.notifications_dao import (
 from app.dao.service_data_retention_dao import (
     fetch_service_data_retention_for_all_services_by_notification_type,
 )
-from app.models import FactProcessingTime, NotificationType
+from app.enums import NotificationType
+from app.models import FactProcessingTime
 from app.utils import get_midnight_in_utc
 
 

app/celery/reporting_tasks.py

@@ -8,7 +8,7 @@ from app.cronitor import cronitor
 from app.dao.fact_billing_dao import fetch_billing_data_for_day, update_fact_billing
 from app.dao.fact_notification_status_dao import update_fact_notification_status
 from app.dao.notifications_dao import get_service_ids_with_notifications_on_date
-from app.models import NotificationType
+from app.enums import NotificationType
 
 
 @notify_celery.task(name="create-nightly-billing")

app/celery/research_mode_tasks.py

@@ -6,7 +6,7 @@ from requests import HTTPError, request
 from app.celery.process_ses_receipts_tasks import process_ses_results
 from app.config import QueueNames
 from app.dao.notifications_dao import get_notification_by_id
-from app.models import NotificationType
+from app.enums import NotificationType
 
 temp_fail = "2028675303"
 perm_fail = "2028675302"

app/celery/scheduled_tasks.py

@@ -34,13 +34,8 @@ from app.dao.services_dao import (
 )
 from app.dao.users_dao import delete_codes_older_created_more_than_a_day_ago
 from app.delivery.send_to_providers import provider_to_use
-from app.models import (
-    JOB_STATUS_ERROR,
-    JOB_STATUS_IN_PROGRESS,
-    JOB_STATUS_PENDING,
-    Job,
-    NotificationType,
-)
+from app.enums import NotificationType
+from app.models import JOB_STATUS_ERROR, JOB_STATUS_IN_PROGRESS, JOB_STATUS_PENDING, Job
 from app.notifications.process_notifications import send_notification_to_queue
 
 MAX_NOTIFICATION_FAILS = 10000

app/celery/tasks.py

@@ -20,13 +20,13 @@ from app.dao.service_email_reply_to_dao import dao_get_reply_to_by_id
 from app.dao.service_inbound_api_dao import get_service_inbound_api_for_service
 from app.dao.service_sms_sender_dao import dao_get_service_sms_senders_by_id
 from app.dao.templates_dao import dao_get_template_by_id
+from app.enums import NotificationType
 from app.models import (
     JOB_STATUS_CANCELLED,
     JOB_STATUS_FINISHED,
     JOB_STATUS_IN_PROGRESS,
     JOB_STATUS_PENDING,
     KEY_TYPE_NORMAL,
-    NotificationType,
 )
 from app.notifications.process_notifications import persist_notification
 from app.notifications.validators import check_service_over_total_message_limit

app/celery/test_key_tasks.py

@@ -6,7 +6,7 @@ from requests import HTTPError, request
 from app.celery.process_ses_receipts_tasks import process_ses_results
 from app.config import QueueNames
 from app.dao.notifications_dao import get_notification_by_id
-from app.models import NotificationType
+from app.enums import NotificationType
 
 temp_fail = "2028675303"
 perm_fail = "2028675302"