darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-31 15:15:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Retrieve billing data (for month) by notification type:

Browse Source 
* Previously we were only returning SMS. Let's make this return for
a given notification type.
* General refactor of the monthly retrieval query
* Return an empty BillingData tuple if email billing data is empty
This commit is contained in:
Imdad Ahad
2017-08-10 17:06:31 +01:00
parent 839c161628
commit 35ad5d74f9
2 changed files with 59 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
tests/app/dao/test_notification_usage_dao.py
View File

@@ -277,7 +277,7 @@ def test_get_monthly_billing_data_with_multiple_rates(notify_db, notify_db_sessi
def test_get_monthly_billing_data_with_no_notifications_for_daterange(notify_db, notify_db_session, sample_template):
set_up_rate(notify_db, datetime(2016, 4, 1), 0.014)
results = get_monthly_billing_data(sample_template.service_id, 2016)
assert len(results) == 0
assert results == []
def set_up_rate(notify_db, start_date, value):
@@ -768,7 +768,8 @@ def test_get_monthly_billing_data_where_start_date_before_rate_returns_empty(
results = get_billing_data_for_month(
service_id=sample_template.service_id,
start_date=now - timedelta(days=2),
end_date=now - timedelta(days=1)
end_date=now - timedelta(days=1),
notification_type=SMS_TYPE
)
assert not results