darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Fix risk of uncaught exceptions due to gds metrics

Browse Source 
Similar to https://github.com/alphagov/notifications-admin/pull/3510

Because of https://github.com/alphagov/gds_metrics_python/pull/8
This commit is contained in:
David McDonald
2020-07-08 16:51:41 +01:00
parent 4de75b8c56
commit 34538bcad8
3 changed files with 8 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/__init__.py
View File

@@ -83,6 +83,9 @@ def create_app(application):
application.config['NOTIFY_APP_NAME'] = application.name application.config['NOTIFY_APP_NAME'] = application.name
init_app(application) init_app(application)
# Metrics intentionally high up to give the most accurate timing and reliability that the metric is recorded
metrics.init_app(application)
request_helper.init_app(application) request_helper.init_app(application)
db.init_app(application) db.init_app(application)
migrate.init_app(application, db=db) migrate.init_app(application, db=db)
@@ -108,7 +111,6 @@ def create_app(application):
redis_store.init_app(application) redis_store.init_app(application)
performance_platform_client.init_app(application) performance_platform_client.init_app(application)
document_download_client.init_app(application) document_download_client.init_app(application)
metrics.init_app(application)
register_blueprint(application) register_blueprint(application)
register_v2_blueprints(application) register_v2_blueprints(application)

2
requirements-app.txt
View File

@@ -33,4 +33,4 @@ git+https://github.com/alphagov/notifications-utils.git@40.2.1#egg=notifications
# gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains # gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains
prometheus-client==0.7.1 prometheus-client==0.7.1
gds-metrics==0.2.0 gds-metrics==0.2.2

8
requirements.txt
View File

@@ -35,21 +35,21 @@ git+https://github.com/alphagov/notifications-utils.git@40.2.1#egg=notifications
# gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains # gds-metrics requires prometheseus 0.2.0, override that requirement as 0.7.1 brings significant performance gains
prometheus-client==0.7.1 prometheus-client==0.7.1
gds-metrics==0.2.0 gds-metrics==0.2.2
## The following requirements were added by pip freeze: ## The following requirements were added by pip freeze:
alembic==1.4.2 alembic==1.4.2
amqp==1.4.9 amqp==1.4.9
anyjson==0.3.3 anyjson==0.3.3
attrs==19.3.0 attrs==19.3.0
awscli==1.18.96 awscli==1.18.97
bcrypt==3.1.7 bcrypt==3.1.7
billiard==3.3.0.23 billiard==3.3.0.23
bleach==3.1.4 bleach==3.1.4
blinker==1.4 blinker==1.4
boto==2.49.0 boto==2.49.0
boto3==1.10.38 boto3==1.10.38
botocore==1.17.19 botocore==1.17.20
certifi==2020.6.20 certifi==2020.6.20
chardet==3.0.4 chardet==3.0.4
click==7.1.2 click==7.1.2
@@ -82,7 +82,7 @@ pytz==2020.1
PyYAML==5.3.1 PyYAML==5.3.1
redis==3.5.3 redis==3.5.3
requests==2.24.0 requests==2.24.0
rsa==3.4.2 rsa==4.5
s3transfer==0.3.3 s3transfer==0.3.3
six==1.15.0 six==1.15.0
smartypants==2.0.1 smartypants==2.0.1