darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-26 01:03:41 -04:00
Code Issues Packages Projects Releases Wiki Activity

try deactivating some letter routes

Browse Source
This commit is contained in:
stvnrlly
2022-12-08 09:55:21 -05:00
parent 14a1d499fa
commit 33bd3b3a31
7 changed files with 22 additions and 295 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
tests/app/service/test_rest.py
View File

@@ -2510,40 +2510,6 @@ def test_create_pdf_letter(mocker, sample_service_full_permissions, client, fake
assert json_resp == {'id': fake_uuid}
@pytest.mark.parametrize('post_data, expected_errors', [
(
{},
[
{'error': 'ValidationError', 'message': 'postage is a required property'},
{'error': 'ValidationError', 'message': 'filename is a required property'},
{'error': 'ValidationError', 'message': 'created_by is a required property'},
{'error': 'ValidationError', 'message': 'file_id is a required property'},
{'error': 'ValidationError', 'message': 'recipient_address is a required property'}
]
),
(
{"postage": "third", "filename": "string", "created_by": "string", "file_id": "string",
"recipient_address": "Some Address"},
[
{'error': 'ValidationError',
'message': 'postage invalid. It must be first, second, europe or rest-of-world.'}
]
)
])
def test_create_pdf_letter_validates_against_json_schema(
sample_service_full_permissions, client, post_data, expected_errors
):
response = client.post(
url_for('service.create_pdf_letter', service_id=sample_service_full_permissions.id),
data=json.dumps(post_data),
headers=[('Content-Type', 'application/json'), create_admin_authorization_header()]
)
json_resp = json.loads(response.get_data(as_text=True))
assert response.status_code == 400
assert json_resp['errors'] == expected_errors
def test_get_notification_for_service_includes_template_redacted(admin_request, sample_notification):
resp = admin_request.get(
'service.get_notification_for_service',
@@ -2555,17 +2521,6 @@ def test_get_notification_for_service_includes_template_redacted(admin_request,
assert resp['template']['redact_personalisation'] is False
def test_get_notification_for_service_includes_precompiled_letter(admin_request, sample_notification):
resp = admin_request.get(
'service.get_notification_for_service',
service_id=sample_notification.service_id,
notification_id=sample_notification.id
)
assert resp['id'] == str(sample_notification.id)
assert resp['template']['is_precompiled_letter'] is False
def test_get_all_notifications_for_service_includes_template_redacted(admin_request, sample_service):
normal_template = create_template(sample_service)