darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 17:31:14 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor a test so it doesn't do query that's tested elsewhere

Browse Source
This commit is contained in:
Pea Tyczynska
2019-12-04 14:40:24 +00:00
parent cfbb080f57
commit 339b6c0ec7
2 changed files with 30 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
tests/app/celery/test_scheduled_tasks.py
View File

@@ -502,7 +502,6 @@ MockServicesSendingToTVNumbers = namedtuple(
'ServicesSendingToTVNumbers', 'ServicesSendingToTVNumbers',
[ [
'service_id', 'service_id',
'service_name',
'notification_count', 'notification_count',
] ]
) )
@@ -517,7 +516,7 @@ MockServicesSendingToTVNumbers = namedtuple(
], ],
[ [
[], [],
[MockServicesSendingToTVNumbers("123", "Service 1", 300)], [MockServicesSendingToTVNumbers("123", 300)],
"1 service(s) have sent over 100 sms messages to tv numbers in last 24 hours:\n" "1 service(s) have sent over 100 sms messages to tv numbers in last 24 hours:\n"
"service id: 123, count of sms to tv numbers: 300,\n" "service id: 123, count of sms to tv numbers: 300,\n"
] ]

55
tests/app/service/test_utils.py
View File

@@ -1,7 +1,7 @@
from app.dao.date_util import get_current_financial_year_start_year from app.dao.date_util import get_current_financial_year_start_year
from freezegun import freeze_time from freezegun import freeze_time
from tests.app.db import create_service, create_notification, create_template
from app.service.utils import get_services_with_high_failure_rates from app.service.utils import get_services_with_high_failure_rates
from collections import namedtuple
from datetime import datetime, timedelta from datetime import datetime, timedelta
@@ -18,32 +18,35 @@ def test_get_current_financial_year_start_year_after_april():
assert current_fy == 2017 assert current_fy == 2017
MockServicesNotificationCounts = namedtuple(
'ServicesSendingToTVNumbers',
[
'service_id',
'status',
'count',
]
)
@freeze_time("2019-12-02 12:00:00.000000") @freeze_time("2019-12-02 12:00:00.000000")
def test_get_services_with_high_failure_rates(notify_db_session): def test_get_services_with_high_failure_rates(mocker, notify_db_session):
service_1 = create_service(service_name="Service 1") mock_query_results = [
service_3 = create_service(service_name="Service 3", restricted=True) # restricted MockServicesNotificationCounts('123', 'delivered', 150),
service_4 = create_service(service_name="Service 4", research_mode=True) # research mode MockServicesNotificationCounts('123', 'permanent-failure', 50), # these will show up
service_5 = create_service(service_name="Service 5", active=False) # not active MockServicesNotificationCounts('456', 'delivered', 150),
services = [service_1, service_3, service_4, service_5] MockServicesNotificationCounts('456', 'permanent-failure', 5), # ratio too low
for service in services: MockServicesNotificationCounts('789', 'permanent-failure', 5), # below threshold
template = create_template(service) MockServicesNotificationCounts('444', 'delivered', 100),
create_notification(template, status="permanent-failure") MockServicesNotificationCounts('444', 'permanent-failure', 100), # these will show up
for x in range(0, 3): ]
create_notification(template, status="delivered") mocker.patch(
'app.service.utils.dao_find_real_sms_notification_count_by_status_for_live_services',
service_6 = create_service(service_name="Service 6") # notifications too old return_value=mock_query_results
with freeze_time("2019-11-30 15:00:00.000000"): )
template_6 = create_template(service_6)
for x in range(0, 4):
create_notification(template_6, status="permanent-failure")
service_2 = create_service(service_name="Service 2") # below threshold
template_2 = create_template(service_2)
create_notification(template_2, status="permanent-failure")
start_date = (datetime.utcnow() - timedelta(days=1)) start_date = (datetime.utcnow() - timedelta(days=1))
end_date = datetime.utcnow() end_date = datetime.utcnow()
assert get_services_with_high_failure_rates(start_date, end_date, threshold=3) == [{ assert get_services_with_high_failure_rates(start_date, end_date) == [
'id': str(service_1.id), {'id': '123', 'permanent_failure_rate': 0.25},
'permanent_failure_rate': 0.25 {'id': '444', 'permanent_failure_rate': 0.5}
}] ]