diff --git a/app/dao/invited_user_dao.py b/app/dao/invited_user_dao.py index a342f504d..631086f30 100644 --- a/app/dao/invited_user_dao.py +++ b/app/dao/invited_user_dao.py @@ -1,5 +1,7 @@ from datetime import timedelta +from sqlalchemy import select + from app import db from app.enums import InvitedUserStatus from app.models import InvitedUser @@ -12,30 +14,37 @@ def save_invited_user(invited_user): def get_invited_user_by_service_and_id(service_id, invited_user_id): - return InvitedUser.query.filter( + + stmt = select(InvitedUser).where( InvitedUser.service_id == service_id, InvitedUser.id == invited_user_id, - ).one() + ) + return db.session.execute(stmt).scalars().one() def get_expired_invite_by_service_and_id(service_id, invited_user_id): - return InvitedUser.query.filter( + stmt = select(InvitedUser).where( InvitedUser.service_id == service_id, InvitedUser.id == invited_user_id, InvitedUser.status == InvitedUserStatus.EXPIRED, - ).one() + ) + return db.session.execute(stmt).scalars().all() def get_invited_user_by_id(invited_user_id): - return InvitedUser.query.filter(InvitedUser.id == invited_user_id).one() + stmt = select(InvitedUser).where(InvitedUser.id == invited_user_id) + return db.session.execute(stmt).scalars().one() def get_expired_invited_users_for_service(service_id): - return InvitedUser.query.filter(InvitedUser.service_id == service_id).all() + # TODO why does this return all invited users? + stmt = select(InvitedUser).where(InvitedUser.service_id == service_id) + return db.session.execute(stmt).scalars().all() def get_invited_users_for_service(service_id): - return InvitedUser.query.filter(InvitedUser.service_id == service_id).all() + stmt = select(InvitedUser).where(InvitedUser.service_id == service_id) + return db.session.execute(stmt).scalars().all() def expire_invitations_created_more_than_two_days_ago(): diff --git a/app/dao/notifications_dao.py b/app/dao/notifications_dao.py index 1d07473c1..cbde45d30 100644 --- a/app/dao/notifications_dao.py +++ b/app/dao/notifications_dao.py @@ -192,6 +192,7 @@ def get_notifications_for_job( ): if page_size is None: page_size = current_app.config["PAGE_SIZE"] + query = Notification.query.filter_by(service_id=service_id, job_id=job_id) query = _filter_query(query, filter_dict) return query.order_by(asc(Notification.job_row_number)).paginate( diff --git a/app/dao/provider_details_dao.py b/app/dao/provider_details_dao.py index b0ab48d09..fca8ebd73 100644 --- a/app/dao/provider_details_dao.py +++ b/app/dao/provider_details_dao.py @@ -1,7 +1,7 @@ from datetime import datetime from flask import current_app -from sqlalchemy import desc, func +from sqlalchemy import desc, func, select from app import db from app.dao.dao_utils import autocommit @@ -11,11 +11,12 @@ from app.utils import utc_now def get_provider_details_by_id(provider_details_id): - return ProviderDetails.query.get(provider_details_id) + return db.session.get(ProviderDetails, provider_details_id) def get_provider_details_by_identifier(identifier): - return ProviderDetails.query.filter_by(identifier=identifier).one() + stmt = select(ProviderDetails).where(identifier=identifier) + return db.session.execute(stmt).scalars().one() def get_alternative_sms_provider(identifier):