diff --git a/app/cloudfoundry_config.py b/app/cloudfoundry_config.py index d886f676f..5cb7c437f 100644 --- a/app/cloudfoundry_config.py +++ b/app/cloudfoundry_config.py @@ -14,12 +14,7 @@ def extract_cloudfoundry_config(): def set_config_env_vars(vcap_services): # Postgres config - db_uri = vcap_services['postgres'][0]['credentials']['uri'] - - sep = "&" if "?" in db_uri else "?" - db_uri += sep + "sslmode=verify-full" - - os.environ['SQLALCHEMY_DATABASE_URI'] = db_uri + os.environ['SQLALCHEMY_DATABASE_URI'] = vcap_services['postgres'][0]['credentials']['uri'] vcap_application = json.loads(os.environ['VCAP_APPLICATION']) os.environ['NOTIFY_ENVIRONMENT'] = vcap_application['space_name'] diff --git a/tests/app/test_cloudfoundry_config.py b/tests/app/test_cloudfoundry_config.py index 3d6331a80..8e1e5b158 100644 --- a/tests/app/test_cloudfoundry_config.py +++ b/tests/app/test_cloudfoundry_config.py @@ -31,35 +31,10 @@ def cloudfoundry_environ(os_environ, cloudfoundry_config): os.environ['VCAP_APPLICATION'] = '{"space_name": "🚀🌌"}' -@pytest.fixture -def postgres_config_with_setting(): - return [ - { - 'credentials': { - 'uri': 'postgres uri?setting=true' - } - } - ] - - -@pytest.fixture -def cloudfoundry_config_with_setting(postgres_config_with_setting): - return { - 'postgres': postgres_config_with_setting, - 'user-provided': [] - } - - -@pytest.fixture -def cloudfoundry_environ_with_setting(os_environ, cloudfoundry_config_with_setting): - os.environ['VCAP_SERVICES'] = json.dumps(cloudfoundry_config_with_setting) - os.environ['VCAP_APPLICATION'] = '{"space_name": "🚀🌌"}' - - def test_extract_cloudfoundry_config_populates_other_vars(cloudfoundry_environ): extract_cloudfoundry_config() - assert os.environ['SQLALCHEMY_DATABASE_URI'] == 'postgres uri?sslmode=verify-full' + assert os.environ['SQLALCHEMY_DATABASE_URI'] == 'postgres uri' assert os.environ['NOTIFY_ENVIRONMENT'] == '🚀🌌' assert os.environ['NOTIFY_LOG_PATH'] == '/home/vcap/logs/app.log' @@ -74,9 +49,3 @@ def test_set_config_env_vars_ignores_unknown_configs(cloudfoundry_config, cloudf assert 'foo' not in os.environ assert 'bar' not in os.environ - - -def test_extract_cloudfoundry_config_populates_postgres_with_setting(cloudfoundry_environ_with_setting): - extract_cloudfoundry_config() - - assert os.environ['SQLALCHEMY_DATABASE_URI'] == 'postgres uri?setting=true&sslmode=verify-full'