Return personalisation dump of notifications + small refactor

app/notifications/rest.py

@@ -11,6 +11,10 @@ from app.dao import (
     templates_dao,
     notifications_dao
 )
+from app.errors import (
+    register_errors,
+    InvalidRequest
+)
 from app.models import KEY_TYPE_TEAM, PRIORITY
 from app.models import SMS_TYPE
 from app.notifications.process_notifications import (
@@ -38,12 +42,6 @@ from notifications_utils.recipients import get_international_phone_info
 
 notifications = Blueprint('notifications', __name__)
 
-from app.errors import (
-    register_errors,
-    InvalidRequest
-)
-
-
 register_errors(notifications)
 
 

app/service/rest.py

@@ -59,6 +59,7 @@ from app.schemas import (
     user_schema,
     permission_schema,
     notification_with_template_schema,
+    notification_with_personalisation_schema,
     notifications_filter_schema,
     detailed_service_schema
 )
@@ -303,7 +304,7 @@ def get_all_notifications_for_service(service_id):
 def search_for_notification_by_to_field(service_id, search_term, statuses):
     results = notifications_dao.dao_get_notifications_by_to_field(service_id, search_term, statuses)
     return jsonify(
-        notifications=notification_with_template_schema.dump(results, many=True).data
+        notifications=notification_with_personalisation_schema.dump(results, many=True).data
     ), 200