From 30f361d318a907caef3cd4c4ab92bd9218a59a91 Mon Sep 17 00:00:00 2001 From: Leo Hemsted Date: Thu, 5 Dec 2019 10:37:39 +0000 Subject: [PATCH] fix flaky test --- tests/app/dao/test_services_dao.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/app/dao/test_services_dao.py b/tests/app/dao/test_services_dao.py index 281a19c17..7fe0597f5 100644 --- a/tests/app/dao/test_services_dao.py +++ b/tests/app/dao/test_services_dao.py @@ -664,8 +664,10 @@ def test_update_service_permission_creates_a_history_record_with_current_data(no EMAIL_TYPE, INTERNATIONAL_SMS_TYPE, LETTER_TYPE, )) - assert len(Service.get_history_model().query.filter_by(name='service_name').all()) == 3 - assert Service.get_history_model().query.filter_by(name='service_name').all()[2].version == 3 + history = Service.get_history_model().query.filter_by(name='service_name').order_by('version').all() + + assert len(history) == 3 + assert history[2].version == 3 def test_create_service_and_history_is_transactional(notify_db_session):