darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-23 08:51:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

Update how "missing ackfile for letters" Zendesk tickets are created

Browse Source
This commit is contained in:
Katie Smith
2021-09-23 16:08:30 +01:00
parent 64c0a3fb9d
commit 2f66e38fb9
2 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
app/celery/nightly_tasks.py
View File

@@ -257,11 +257,14 @@ def letter_raise_alert_if_no_ack_file_for_zip():
if len(zip_file_set - ack_file_set) > 0: if len(zip_file_set - ack_file_set) > 0:
if current_app.config['NOTIFY_ENVIRONMENT'] in ['live', 'production', 'test']: if current_app.config['NOTIFY_ENVIRONMENT'] in ['live', 'production', 'test']:
zendesk_client.create_ticket( ticket = NotifySupportTicket(
subject="Letter acknowledge error", subject="Letter acknowledge error",
message=message, message=message,
ticket_type=zendesk_client.TYPE_INCIDENT ticket_type=NotifySupportTicket.TYPE_INCIDENT,
technical_ticket=True,
ticket_categories=['notify_letters']
) )
zendesk_client.send_ticket_to_zendesk(ticket)
current_app.logger.error(message) current_app.logger.error(message)
if len(ack_file_set - zip_file_set) > 0: if len(ack_file_set - zip_file_set) > 0:

14
tests/app/celery/test_nightly_tasks.py
View File

@@ -374,7 +374,11 @@ def test_letter_raise_alert_if_no_ack_file_for_zip_does_not_raise_when_files_mat
@freeze_time('2018-01-11T23:00:00') @freeze_time('2018-01-11T23:00:00')
def test_letter_raise_alert_if_ack_files_not_match_zip_list(mocker, notify_db): def test_letter_raise_alert_if_ack_files_not_match_zip_list(mocker, notify_db):
mock_file_list = mocker.patch("app.aws.s3.get_list_of_files_by_suffix", side_effect=mock_s3_get_list_diff) mock_file_list = mocker.patch("app.aws.s3.get_list_of_files_by_suffix", side_effect=mock_s3_get_list_diff)
mock_zendesk = mocker.patch("app.celery.nightly_tasks.zendesk_client.create_ticket") mock_create_ticket = mocker.spy(NotifySupportTicket, '__init__')
mock_send_ticket_to_zendesk = mocker.patch(
'app.celery.nightly_tasks.zendesk_client.send_ticket_to_zendesk',
autospec=True,
)
letter_raise_alert_if_no_ack_file_for_zip() letter_raise_alert_if_no_ack_file_for_zip()
@@ -387,11 +391,15 @@ def test_letter_raise_alert_if_ack_files_not_match_zip_list(mocker, notify_db):
current_app.config['LETTERS_PDF_BUCKET_NAME'], current_app.config['LETTERS_PDF_BUCKET_NAME'],
datetime.utcnow().strftime('%Y-%m-%d') + '/zips_sent', datetime.utcnow().strftime('%Y-%m-%d') + '/zips_sent',
current_app.config['DVLA_RESPONSE_BUCKET_NAME']) current_app.config['DVLA_RESPONSE_BUCKET_NAME'])
mock_zendesk.assert_called_once_with( mock_create_ticket.assert_called_once_with(
ANY,
subject="Letter acknowledge error", subject="Letter acknowledge error",
message=message, message=message,
ticket_type='incident' ticket_type='incident',
technical_ticket=True,
ticket_categories=['notify_letters']
) )
mock_send_ticket_to_zendesk.assert_called_once()
@freeze_time('2018-01-11T23:00:00') @freeze_time('2018-01-11T23:00:00')