darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-03 09:51:11 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1562 from alphagov/fix-phone-validator-bug

Browse Source 
Add validation to check that sms recipient is not None
This commit is contained in:
Katie Smith
2018-01-15 11:00:33 +00:00
committed by GitHub
parent f206c5d032 7b4abd076b
commit 2f2fc712df
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
app/notifications/validators.py
View File

@@ -98,6 +98,9 @@ def check_service_can_schedule_notification(permissions, scheduled_for):
def validate_and_format_recipient(send_to, key_type, service, notification_type): def validate_and_format_recipient(send_to, key_type, service, notification_type):
if send_to is None:
raise BadRequestError(message="Recipient can't be empty")
service_can_send_to_recipient(send_to, key_type, service) service_can_send_to_recipient(send_to, key_type, service)
if notification_type == SMS_TYPE: if notification_type == SMS_TYPE:

7
tests/app/notifications/test_validators.py
View File

@@ -347,6 +347,13 @@ def test_allows_api_calls_with_international_numbers_if_service_does_allow_int_s
assert result == '201212341234' assert result == '201212341234'
def test_rejects_api_calls_with_no_recipient():
with pytest.raises(BadRequestError) as e:
validate_and_format_recipient(None, 'key_type', 'service', 'SMS_TYPE')
assert e.value.status_code == 400
assert e.value.message == "Recipient can't be empty"
@pytest.mark.parametrize('notification_type', ['sms', 'email', 'letter']) @pytest.mark.parametrize('notification_type', ['sms', 'email', 'letter'])
def test_check_service_email_reply_to_id_where_reply_to_id_is_none(notification_type): def test_check_service_email_reply_to_id_where_reply_to_id_is_none(notification_type):
assert check_service_email_reply_to_id(None, None, notification_type) is None assert check_service_email_reply_to_id(None, None, notification_type) is None