fix test

tests/app/service/test_rest.py

@@ -1770,9 +1770,6 @@ def test_get_all_notifications_for_service_in_order_with_post_request(
     assert response.status_code == 200
 
 
-@pytest.mark.skip(
-    reason="We can't search on recipient if recipient is not kept in the db"
-)
 def test_get_all_notifications_for_service_filters_notifications_when_using_post_request(
     client, notify_db_session
 ):
@@ -1808,7 +1805,6 @@ def test_get_all_notifications_for_service_filters_notifications_when_using_post
         "page": 1,
         "template_type": [TemplateType.SMS],
         "status": [NotificationStatus.CREATED, NotificationStatus.SENDING],
-        "to": "0855",
     }
 
     response = client.post(
@@ -1818,7 +1814,7 @@ def test_get_all_notifications_for_service_filters_notifications_when_using_post
     )
 
     resp = json.loads(response.get_data(as_text=True))
-    assert len(resp["notifications"]) == 1
+    assert len(resp["notifications"]) == 2
     assert resp["notifications"][0]["to"] == "1"
     assert resp["notifications"][0]["status"] == returned_notification.status
     assert response.status_code == 200

tests/app/test_commands.py

@@ -428,23 +428,22 @@ def test_promote_user_to_platform_admin(
     assert user.platform_admin is True
 
 
-def test_download_csv_file_by_name(notify_api, sample_platform_admin):
-    assert sample_platform_admin.platform_admin is True
-
-    result = notify_api.test_cli_runner().invoke(
+def test_download_csv_file_by_name(notify_api, mocker):
+    mock_download = mocker.patch("app.commands.s3.download_from_s3")
+    notify_api.test_cli_runner().invoke(
         download_csv_file_by_name,
         [
+            "-f",
             "NonExistentName",
         ],
     )
-
-    # if we get a 404, it means that the file is not in s3 (of course)
-    # but we are making the call to s3, etc. so that part is working
-    assert "404" in str(result)
+    mock_download.assert_called_once()
 
 
 def test_promote_user_to_platform_admin_no_result_found(
-    notify_db_session, notify_api, sample_user
+    notify_db_session,
+    notify_api,
+    sample_user,
 ):
     assert sample_user.platform_admin is False