From 459c000584031282263aa81a069b863064ec84ce Mon Sep 17 00:00:00 2001
From: Kenneth Kehl <@kkehl@flexion.us>
Date: Wed, 6 Aug 2025 10:59:32 -0700
Subject: [PATCH 1/2] try again

---
 notifications_utils/s3.py | 24 ++++++++++--------------
 1 file changed, 10 insertions(+), 14 deletions(-)

diff --git a/notifications_utils/s3.py b/notifications_utils/s3.py
index e7b91dcab..310e90f09 100644
--- a/notifications_utils/s3.py
+++ b/notifications_utils/s3.py
@@ -1,4 +1,3 @@
-import os
 import urllib
 
 import botocore
@@ -6,6 +5,9 @@ from boto3 import Session
 from botocore.config import Config
 from flask import current_app
 
+from app.config import _s3_credentials_from_env
+from app.utils import hilite
+
 AWS_CLIENT_CONFIG = Config(
     # This config is required to enable S3 to connect to FIPS-enabled
     # endpoints.  See https://aws.amazon.com/compliance/fips/ for more
@@ -16,18 +18,17 @@ AWS_CLIENT_CONFIG = Config(
     max_pool_connections=50,
     use_fips_endpoint=True,
 )
-
-
-default_access_key_id = os.environ.get("CSV_AWS_ACCESS_KEY_ID")
-default_secret_access_key = os.environ.get("CSV_AWS_SECRET_ACCESS_KEY")
-default_region = os.environ.get("CSV_AWS_REGION")
+default_regions = "us-gov-west-1"
 
 
 def get_s3_resource():
+
+    credentials = _s3_credentials_from_env("CSV")
+    current_app.logger.info(hilite(f"CREDENTIALS {credentials}"))
     session = Session(
-        aws_access_key_id=os.environ.get("CSV_AWS_ACCESS_KEY_ID"),
-        aws_secret_access_key=os.environ.get("CSV_AWS_SECRET_ACCESS_KEY"),
-        region_name=os.environ.get("CSV_AWS_REGION"),
+        aws_access_key_id=credentials["access_key_id"],
+        aws_secret_access_key=credentials["secret_access_key"],
+        region_name=credentials["region"],
     )
     noti_s3_resource = session.resource("s3", config=AWS_CLIENT_CONFIG)
     return noti_s3_resource
@@ -41,8 +42,6 @@ def s3upload(
     content_type="binary/octet-stream",
     tags=None,
     metadata=None,
-    access_key=default_access_key_id,
-    secret_key=default_secret_access_key,
 ):
     _s3 = get_s3_resource()
 
@@ -83,9 +82,6 @@ class S3ObjectNotFound(botocore.exceptions.ClientError):
 def s3download(
     bucket_name,
     filename,
-    region=default_region,
-    access_key=default_access_key_id,
-    secret_key=default_secret_access_key,
 ):
     try:
         s3 = get_s3_resource()

From e0344ea891043fdd131dab376bdebfc7630235a4 Mon Sep 17 00:00:00 2001
From: Kenneth Kehl <@kkehl@flexion.us>
Date: Wed, 6 Aug 2025 11:00:43 -0700
Subject: [PATCH 2/2] fix

---
 notifications_utils/s3.py | 2 --
 1 file changed, 2 deletions(-)

diff --git a/notifications_utils/s3.py b/notifications_utils/s3.py
index 310e90f09..c39d3e3ea 100644
--- a/notifications_utils/s3.py
+++ b/notifications_utils/s3.py
@@ -6,7 +6,6 @@ from botocore.config import Config
 from flask import current_app
 
 from app.config import _s3_credentials_from_env
-from app.utils import hilite
 
 AWS_CLIENT_CONFIG = Config(
     # This config is required to enable S3 to connect to FIPS-enabled
@@ -24,7 +23,6 @@ default_regions = "us-gov-west-1"
 def get_s3_resource():
 
     credentials = _s3_credentials_from_env("CSV")
-    current_app.logger.info(hilite(f"CREDENTIALS {credentials}"))
     session = Session(
         aws_access_key_id=credentials["access_key_id"],
         aws_secret_access_key=credentials["secret_access_key"],