darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-20 14:29:25 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2617 from alphagov/notification-count-for-job

Browse Source 
Return count of notifications in the database for a job
This commit is contained in:
Rebecca Law
2019-10-03 16:54:30 +01:00
committed by GitHub
parent 8f6b0baba0 7fc7d99dac
commit 2c41d6130c
4 changed files with 59 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

22
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -15,6 +15,7 @@ from app.dao.notifications_dao import (
dao_get_last_notification_added_for_job_id,
dao_get_last_template_usage,
dao_get_notifications_by_to_field,
dao_get_notification_count_for_job_id,
dao_get_scheduled_notifications,
dao_timeout_notifications,
dao_update_notification,
@@ -554,6 +555,27 @@ def test_get_all_notifications_for_job_by_status(sample_job):
assert len(notifications(filter_dict={'status': NOTIFICATION_STATUS_TYPES[:3]}).items) == 3
def test_dao_get_notification_count_for_job_id(notify_db_session):
service = create_service()
template = create_template(service)
job = create_job(template, notification_count=3)
for i in range(3):
create_notification(job=job)
create_notification(template)
assert dao_get_notification_count_for_job_id(job_id=job.id) == 3
def test_dao_get_notification_count_for_job_id_returns_zero_for_no_notifications_for_job(notify_db_session):
service = create_service()
template = create_template(service)
job = create_job(template, notification_count=3)
create_notification(template)
assert dao_get_notification_count_for_job_id(job_id=job.id) == 0
def test_update_notification_sets_status(sample_notification):
assert sample_notification.status == 'created'
sample_notification.status = 'failed'