From 2c3689868486977e2b957aaeb0e70cf95e33d756 Mon Sep 17 00:00:00 2001 From: Rebecca Law Date: Tue, 15 Jun 2021 15:12:46 +0100 Subject: [PATCH] Add permanent-failure for letters. It's possible a letter can pass our validation but our print provider can not print the letter. The letter will be marked as permanent failure in this case. Typically happens with precompiled letters. --- app/models.py | 1 + tests/app/test_model.py | 1 + 2 files changed, 2 insertions(+) diff --git a/app/models.py b/app/models.py index 7d3e1b7b8..33a125d7f 100644 --- a/app/models.py +++ b/app/models.py @@ -1577,6 +1577,7 @@ class Notification(db.Model): }, 'letter': { 'technical-failure': 'Technical failure', + 'permanent-failure': 'Permanent failure', 'sending': 'Accepted', 'created': 'Accepted', 'delivered': 'Received', diff --git a/tests/app/test_model.py b/tests/app/test_model.py index 7d473fc2a..0942cdbb9 100644 --- a/tests/app/test_model.py +++ b/tests/app/test_model.py @@ -124,6 +124,7 @@ def test_notification_for_csv_returns_correct_job_row_number(sample_job): ('letter', 'created', 'Accepted'), ('letter', 'sending', 'Accepted'), ('letter', 'technical-failure', 'Technical failure'), + ('letter', 'permanent-failure', 'Permanent failure'), ('letter', 'delivered', 'Received') ]) def test_notification_for_csv_returns_formatted_status(