From 2c17825c128d25d0031cb15f66840dea9320936b Mon Sep 17 00:00:00 2001 From: Chris Hill-Scott Date: Fri, 2 Sep 2016 23:13:32 +0100 Subject: [PATCH] =?UTF-8?q?Don=E2=80=99t=20use=20magic=20string=20for=20jo?= =?UTF-8?q?b=20status?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- app/dao/jobs_dao.py | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/app/dao/jobs_dao.py b/app/dao/jobs_dao.py index 74d9a4f90..0d4634d56 100644 --- a/app/dao/jobs_dao.py +++ b/app/dao/jobs_dao.py @@ -2,7 +2,7 @@ from datetime import date, timedelta, datetime from sqlalchemy import desc, asc, cast, Date as sql_date from app import db from app.dao import days_ago -from app.models import Job, NotificationHistory +from app.models import Job, NotificationHistory, JOB_STATUS_SCHEDULED from app.statsd_decorators import statsd from sqlalchemy import func, asc @@ -39,7 +39,7 @@ def dao_get_job_by_id(job_id): def dao_get_scheduled_jobs(): return Job.query \ - .filter(Job.job_status == 'scheduled', Job.scheduled_for < datetime.utcnow()) \ + .filter(Job.job_status == JOB_STATUS_SCHEDULED, Job.scheduled_for < datetime.utcnow()) \ .order_by(asc(Job.scheduled_for)) \ .all() @@ -49,7 +49,7 @@ def dao_get_future_scheduled_job_by_id_and_service_id(job_id, service_id): .filter( Job.service_id == service_id, Job.id == job_id, - Job.job_status == 'scheduled', + Job.job_status == JOB_STATUS_SCHEDULED, Job.scheduled_for > datetime.utcnow() ) \ .one()