diff --git a/tests/app/celery/test_tasks.py b/tests/app/celery/test_tasks.py index 37b5093d0..aec754601 100644 --- a/tests/app/celery/test_tasks.py +++ b/tests/app/celery/test_tasks.py @@ -1060,6 +1060,8 @@ def test_update_dvla_job_to_error(sample_letter_template, sample_letter_job): update_dvla_job_to_error(job_id=sample_letter_job.id) updated_notifications = Notification.query.all() - assert [(n.status == 'created', n.sent_by == 'dvla') for n in updated_notifications] + for n in updated_notifications: + assert n.status == 'created' + assert not n.sent_by assert 'error' == Job.query.filter_by(id=sample_letter_job.id).one().job_status diff --git a/tests/app/job/test_rest.py b/tests/app/job/test_rest.py index 40e30d38e..05e9d00e5 100644 --- a/tests/app/job/test_rest.py +++ b/tests/app/job/test_rest.py @@ -673,7 +673,7 @@ def test_get_jobs_accepts_page_parameter( @pytest.mark.parametrize('statuses_filter, expected_statuses', [ ('', JOB_STATUS_TYPES), ('pending', [JOB_STATUS_PENDING]), - ('pending, in progress, finished, sending limits exceeded, scheduled, cancelled, ready to send, sent to dvla', + ('pending, in progress, finished, sending limits exceeded, scheduled, cancelled, ready to send, sent to dvla, error', # noqa JOB_STATUS_TYPES), # bad statuses are accepted, just return no data ('foo', []) @@ -694,6 +694,7 @@ def test_get_jobs_can_filter_on_statuses( create_job(notify_db, notify_db_session, job_status='cancelled') create_job(notify_db, notify_db_session, job_status='ready to send') create_job(notify_db, notify_db_session, job_status='sent to dvla') + create_job(notify_db, notify_db_session, job_status='error') path = '/service/{}/job'.format(sample_service.id) response = client.get(