darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-17 10:42:25 -05:00
Code Issues Packages Projects Releases Wiki Activity

retry service callbacks on 429

Browse Source 
if we're served a 429, put the item on the retry queue and retry the
same as if the service returned a 5xx. 429 is commonly returned for rate
limit exceeding, and retrying on a delay is a typical response to that.
This commit is contained in:
Leo Hemsted
2021-07-13 16:09:17 +01:00
parent 719ba698e2
commit 2ad9a3a380
2 changed files with 8 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
app/celery/service_callback_tasks.py
View File

@@ -86,7 +86,7 @@ def _send_data_to_service_callback_api(self, data, service_callback_url, token,
e e
) )
) )
if not isinstance(e, HTTPError) or e.response.status_code >= 500: if not isinstance(e, HTTPError) or e.response.status_code >= 500 or e.response.status_code == 429:
try: try:
self.retry(queue=QueueNames.CALLBACKS_RETRY) self.retry(queue=QueueNames.CALLBACKS_RETRY)
except self.MaxRetriesExceededError: except self.MaxRetriesExceededError:

10
tests/app/celery/test_service_callback_tasks.py
View File

@@ -92,8 +92,12 @@ def test_send_complaint_to_service_posts_https_request_to_service_with_encrypted
@pytest.mark.parametrize("notification_type", ["email", "sms"]) @pytest.mark.parametrize("notification_type", ["email", "sms"])
def test__send_data_to_service_callback_api_retries_if_request_returns_500_with_encrypted_data( @pytest.mark.parametrize('status_code', [429, 500, 503])
notify_db_session, mocker, notification_type def test__send_data_to_service_callback_api_retries_if_request_returns_error_code_with_encrypted_data(
notify_db_session,
mocker,
notification_type,
status_code
): ):
callback_api, template = _set_up_test_data(notification_type, "delivery_status") callback_api, template = _set_up_test_data(notification_type, "delivery_status")
datestr = datetime(2017, 6, 20) datestr = datetime(2017, 6, 20)
@@ -108,7 +112,7 @@ def test__send_data_to_service_callback_api_retries_if_request_returns_500_with_
with requests_mock.Mocker() as request_mock: with requests_mock.Mocker() as request_mock:
request_mock.post(callback_api.url, request_mock.post(callback_api.url,
json={}, json={},
status_code=500) status_code=status_code)
send_delivery_status_to_service(notification.id, encrypted_status_update=encrypted_data) send_delivery_status_to_service(notification.id, encrypted_status_update=encrypted_data)
assert mocked.call_count == 1 assert mocked.call_count == 1