darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-17 18:52:30 -05:00
Code Issues Packages Projects Releases Wiki Activity

put number all on one line

Browse Source
This commit is contained in:
Kenneth Kehl
2024-11-12 14:40:18 -08:00
parent 5cd0e1e523
commit 2a8b1374b0
1 changed files with 8 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
app/clients/sms/aws_sns.py
View File

@@ -63,13 +63,15 @@ class AwsSnsClient(SmsClient):
} }
} }
non_scrubbable = " ".join(sender)
default_num = " ".join(self.current_app.config["AWS_US_TOLL_FREE_NUMBER"])
self.current_app.logger.info(
f"notify-api-1385 sender {non_scrubbable} is a {type(sender)} default is a {type(default_num)}"
)
if self._valid_sender_number(sender): if self._valid_sender_number(sender):
self.current_app.logger.info( self.current_app.logger.info(
"aws_sns found a valid sender number here it is wait for it!" f"notify-api-1385 use valid sender {non_scrubbable} instead of default {default_num}"
) )
# To defeat scrubbing, sender numbers are not PII.
non_scrubbable = " ".join(sender)
self.current_app.logger.info(non_scrubbable)
attributes["AWS.MM.SMS.OriginationNumber"] = { attributes["AWS.MM.SMS.OriginationNumber"] = {
"DataType": "String", "DataType": "String",
@@ -77,8 +79,9 @@ class AwsSnsClient(SmsClient):
} }
else: else:
self.current_app.logger.info( self.current_app.logger.info(
"aws_sns did not find a valid sender number, defaulting to the toll free one" f"notify-api-1385 use default {default_num} instead of invalid sender {non_scrubbable}"
) )
attributes["AWS.MM.SMS.OriginationNumber"] = { attributes["AWS.MM.SMS.OriginationNumber"] = {
"DataType": "String", "DataType": "String",
"StringValue": self.current_app.config["AWS_US_TOLL_FREE_NUMBER"], "StringValue": self.current_app.config["AWS_US_TOLL_FREE_NUMBER"],