darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Strip leading 44 from inbound SMS numbers to normalise to how we store things.

Browse Source
This commit is contained in:
Martyn Inglis
2017-06-06 11:50:30 +01:00
parent 85b9968473
commit 29455b6d3b
2 changed files with 30 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
app/notifications/receive_notifications.py
View File

@@ -27,10 +27,13 @@ def receive_mmg_sms():
}
"""
post_data = request.get_json()
potential_services = dao_fetch_services_by_sms_sender(post_data['Number'])
inbound_number = strip_leading_forty_four(post_data['Number'])
potential_services = dao_fetch_services_by_sms_sender(inbound_number)
if len(potential_services) != 1:
current_app.logger.error('Inbound number "{}" not associated with exactly one service'.format(
current_app.logger.error('Inbound number "{}" from MMG not associated with exactly one service'.format(
post_data['Number']
))
statsd_client.incr('inbound.mmg.failed')
@@ -88,9 +91,11 @@ def create_inbound_mmg_sms_object(service, json):
def receive_firetext_sms():
post_data = request.form
potential_services = dao_fetch_services_by_sms_sender(post_data['destination'])
inbound_number = strip_leading_forty_four(post_data['destination'])
potential_services = dao_fetch_services_by_sms_sender(inbound_number)
if len(potential_services) != 1:
current_app.logger.error('Inbound number "{}" not associated with exactly one service'.format(
current_app.logger.error('Inbound number "{}" from firetext not associated with exactly one service'.format(
post_data['destination']
))
statsd_client.incr('inbound.firetext.failed')
@@ -120,3 +125,9 @@ def receive_firetext_sms():
return jsonify({
"status": "ok"
}), 200
def strip_leading_forty_four(number):
if number.startswith('44'):
return number.replace('44', '0', 1)
return number