From 425cc8340e69f3c4b2e6c0119df8297da0882273 Mon Sep 17 00:00:00 2001
From: Chris Hill-Scott <me@quis.cc>
Date: Wed, 20 Apr 2016 10:33:41 +0100
Subject: [PATCH] Fix missing import on notification stats endpoint
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The response import was missing, which broke things.

There was no test to catch this.

This commit adds a rudimentary test to make sure that the endpoint
doesn’t 500, at the very least.
---
 app/notifications_statistics/rest.py |  1 +
 tests/app/notifications/test_rest.py | 25 +++++++++++++++++++++++++
 2 files changed, 26 insertions(+)

diff --git a/app/notifications_statistics/rest.py b/app/notifications_statistics/rest.py
index 5f3a66483..327b1cd04 100644
--- a/app/notifications_statistics/rest.py
+++ b/app/notifications_statistics/rest.py
@@ -1,6 +1,7 @@
 from flask import (
     Blueprint,
     jsonify,
+    request
 )
 
 from app.dao.notifications_dao import (
diff --git a/tests/app/notifications/test_rest.py b/tests/app/notifications/test_rest.py
index e35c06bea..e2687cb64 100644
--- a/tests/app/notifications/test_rest.py
+++ b/tests/app/notifications/test_rest.py
@@ -492,6 +492,31 @@ def test_filter_by_status_and_template_type(notify_api,
             assert response.status_code == 200
 
 
+def test_get_notification_statistics(
+    notify_api,
+    notify_db,
+    notify_db_session,
+    sample_template,
+    sample_email_template
+):
+    with notify_api.test_request_context():
+        with notify_api.test_client() as client:
+
+            path = '/service/{}/notifications-statistics'.format(sample_email_template.service)
+
+            auth_header = create_authorization_header(
+                service_id=sample_email_template.service_id,
+                path=path,
+                method='GET')
+
+            response = client.get(path, headers=[auth_header])
+            assert response.status_code == 404
+
+            stats = json.loads(response.get_data(as_text=True))
+            assert stats['result'] == 'error'
+            assert stats['message'] == 'No result found'
+
+
 def test_create_sms_should_reject_if_missing_required_fields(notify_api, sample_api_key, mocker):
     with notify_api.test_request_context():
         with notify_api.test_client() as client: