darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 07:35:34 -05:00
Code Issues Packages Projects Releases Wiki Activity

Search for emails or texts, depending on term

Browse Source 
The caseworking view is going to have a page which displays emails and
text messages combined together.

In order for the search to work on this page the user needs to be able
to search for an email or a text message. This commit makes it guess
what to search for when the `notification_type` isn’t known (basically
by saying ‘if the search term is only digits they’re probably looking
searching by phone number’).
This commit is contained in:
Chris Hill-Scott
2018-06-13 16:04:49 +01:00
parent 6d91867dcf
commit 27faf7912b
2 changed files with 32 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -1553,20 +1553,34 @@ def test_dao_get_notifications_by_to_field_search_ignores_spaces(sample_template
assert notification3.id in notification_ids
def test_dao_get_notifications_by_to_field_only_searches_for_notification_type(
notify_db_session
@pytest.mark.parametrize('phone_search', (
'077', '7-7', '+44(0)7711 111111'
))
@pytest.mark.parametrize('email_search', (
'example', 'eXaMpLe',
))
def test_dao_get_notifications_by_to_field_only_searches_one_notification_type(
notify_db_session,
phone_search,
email_search,
):
service = create_service()
sms_template = create_template(service=service)
email_template = create_template(service=service, template_type='email')
sms = create_notification(template=sms_template, to_field='0771111111', normalised_to='0771111111')
sms = create_notification(template=sms_template, to_field='07711111111', normalised_to='447711111111')
email = create_notification(
template=email_template, to_field='077@example.com', normalised_to='077@example.com'
)
results = dao_get_notifications_by_to_field(service.id, "077", notification_type='sms')
results = dao_get_notifications_by_to_field(service.id, phone_search, notification_type='sms')
assert len(results) == 1
assert results[0].id == sms.id
results = dao_get_notifications_by_to_field(service.id, "077", notification_type='email')
results = dao_get_notifications_by_to_field(service.id, phone_search) # should assume SMS
assert len(results) == 1
assert results[0].id == sms.id
results = dao_get_notifications_by_to_field(service.id, '077', notification_type='email')
assert len(results) == 1
assert results[0].id == email.id
results = dao_get_notifications_by_to_field(service.id, email_search) # should assume email
assert len(results) == 1
assert results[0].id == email.id