darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-18 21:48:49 -04:00
Code Issues Packages Projects Releases Wiki Activity

Refactor postcode validation to use utils

Browse Source 
We don’t need to reformat the postcode here once template preview takes
care of it when rendering the PDF.

It’s better (and less code) to store what people give us, so we give
them back the same thing.
This commit is contained in:
Chris Hill-Scott
2020-04-03 13:13:57 +01:00
parent e2985161bb
commit 264fbed04e
6 changed files with 14 additions and 23 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/celery/test_tasks.py
View File

@@ -1048,7 +1048,7 @@ def test_save_letter_saves_letter_to_database_with_formatted_postcode(mocker, no
notification_db = Notification.query.one()
assert notification_db.id == notification_id
assert notification_db.personalisation["postcode"] == "SE16 4SA"
assert notification_db.personalisation["postcode"] == "se1 64sa"
def test_save_letter_saves_letter_to_database_right_reply_to(mocker, notify_db_session):

4
tests/app/v2/notifications/test_post_letter_notifications.py
View File

@@ -139,7 +139,9 @@ def test_post_letter_notification_formats_postcode(
assert validate(resp_json, post_letter_response) == resp_json
notification = Notification.query.one()
assert notification.personalisation["postcode"] == "SW1 1AA"
# We store what the client gives us, and only reformat it when
# generating the PDF
assert notification.personalisation["postcode"] == ' Sw1 1aa '
def test_post_letter_notification_throws_error_for_bad_postcode(