darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-08-19 14:08:47 -04:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1692 from alphagov/service-name-change

Browse Source 
don't return or accept sms_sender in update service anymore
This commit is contained in:
Leo Hemsted
2018-02-22 14:37:47 +00:00
committed by GitHub
parent 18a85a080d aedbd37d8b
commit 25d6b45ea2
2 changed files with 1 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/service/test_rest.py
View File

@@ -137,7 +137,6 @@ def test_get_service_by_id(admin_request, sample_service):
assert json_resp['data']['email_branding'] is None
assert json_resp['data']['branding'] == 'govuk'
assert json_resp['data']['dvla_organisation'] == '001'
assert json_resp['data']['sms_sender'] == current_app.config['FROM_NUMBER']
assert json_resp['data']['prefix_sms'] is True
@@ -198,7 +197,6 @@ def test_get_service_by_id_and_user(client, sample_service, sample_user):
json_resp = json.loads(resp.get_data(as_text=True))
assert json_resp['data']['name'] == sample_service.name
assert json_resp['data']['id'] == str(sample_service.id)
assert json_resp['data']['reply_to_email_address'] == 'new@service.com'
def test_get_service_by_id_should_404_if_no_service_for_user(notify_api, sample_user):
@@ -239,7 +237,6 @@ def test_create_service(client, sample_user):
assert json_resp['data']['email_from'] == 'created.service'
assert not json_resp['data']['research_mode']
assert json_resp['data']['dvla_organisation'] == '001'
assert json_resp['data']['sms_sender'] == current_app.config['FROM_NUMBER']
assert json_resp['data']['rate_limit'] == 3000
service_db = Service.query.get(json_resp['data']['id'])
@@ -1425,7 +1422,6 @@ def test_set_sms_prefixing_for_service(
_data={'prefix_sms': posted_value},
)
assert result['data']['prefix_sms'] == stored_value
assert result['data']['sms_sender'] == current_app.config['FROM_NUMBER']
def test_set_sms_prefixing_for_service_cant_be_none(