From 23cfe73c488072968bd501838021df4d6d2f519b Mon Sep 17 00:00:00 2001 From: Athanasios Voutsadakis Date: Wed, 11 Apr 2018 15:01:45 +0100 Subject: [PATCH] Add 5 second sleep before stopping old api instances This is to allow the new instances to start responding to the http healthchecks and start serving traffic. --- Makefile | 1 + 1 file changed, 1 insertion(+) diff --git a/Makefile b/Makefile index ebf56145a..57585e43b 100644 --- a/Makefile +++ b/Makefile @@ -208,6 +208,7 @@ cf-deploy: ## Deploys the app to Cloud Foundry cf rename ${CF_APP} ${CF_APP}-rollback cf push ${CF_APP} -f <(make -s generate-manifest) cf scale -i $$(cf curl /v2/apps/$$(cf app --guid ${CF_APP}-rollback) | jq -r ".entity.instances" 2>/dev/null || echo "1") ${CF_APP} + if [ "${CF_APP}" == "notify-api" ]; then sleep 5; fi cf stop ${CF_APP}-rollback # sleep for 10 seconds to try and make sure that all worker threads (either web api or celery) have finished before we delete # when we delete the DB is unbound from the app, which can cause "permission denied for relation" psycopg2 errors.