mirror of
https://github.com/GSA/notifications-api.git
synced 2026-08-18 13:38:53 -04:00
Add before_request check for request size
The test checks various routes to ensure that request above our threshold fail before any other processing happens
This commit is contained in:
@@ -19,6 +19,7 @@ from notifications_utils.clients.encryption.encryption_client import Encryption
|
|||||||
from notifications_utils import logging, request_helper
|
from notifications_utils import logging, request_helper
|
||||||
from sqlalchemy import event
|
from sqlalchemy import event
|
||||||
from werkzeug.exceptions import HTTPException as WerkzeugHTTPException
|
from werkzeug.exceptions import HTTPException as WerkzeugHTTPException
|
||||||
|
from werkzeug.exceptions import RequestEntityTooLarge as WerkzeugRequestEntityTooLarge
|
||||||
from werkzeug.local import LocalProxy
|
from werkzeug.local import LocalProxy
|
||||||
|
|
||||||
from app.celery.celery import NotifyCelery
|
from app.celery.celery import NotifyCelery
|
||||||
@@ -281,6 +282,15 @@ def init_app(app):
|
|||||||
g.start = monotonic()
|
g.start = monotonic()
|
||||||
g.endpoint = request.endpoint
|
g.endpoint = request.endpoint
|
||||||
|
|
||||||
|
@app.before_request
|
||||||
|
def check_content_length():
|
||||||
|
if (
|
||||||
|
request.content_length is not None
|
||||||
|
and current_app.config['MAX_CONTENT_LENGTH'] is not None
|
||||||
|
and request.content_length > current_app.config['MAX_CONTENT_LENGTH']
|
||||||
|
):
|
||||||
|
raise WerkzeugRequestEntityTooLarge()
|
||||||
|
|
||||||
@app.after_request
|
@app.after_request
|
||||||
def after_request(response):
|
def after_request(response):
|
||||||
CONCURRENT_REQUESTS.dec()
|
CONCURRENT_REQUESTS.dec()
|
||||||
|
|||||||
36
tests/app/test_request_size.py
Normal file
36
tests/app/test_request_size.py
Normal file
@@ -0,0 +1,36 @@
|
|||||||
|
import pytest
|
||||||
|
import json
|
||||||
|
|
||||||
|
@pytest.mark.parametrize('endpoint, max_content_length, expected_status_code', [
|
||||||
|
("/_status", 5*1024*1024, 413),
|
||||||
|
("/provider-details", 5*1024*1024, 413),
|
||||||
|
("/v2/notifications/email", 5*1024*1024, 413),
|
||||||
|
|
||||||
|
("/_status", None, 200),
|
||||||
|
("/provider-details", None, 405),
|
||||||
|
("/v2/notifications/email", None, 401),
|
||||||
|
])
|
||||||
|
def test_request_status_when_content_length_is_set(
|
||||||
|
notify_api,
|
||||||
|
sample_email_template_with_placeholders,
|
||||||
|
mocker,
|
||||||
|
endpoint,
|
||||||
|
max_content_length,
|
||||||
|
expected_status_code):
|
||||||
|
|
||||||
|
notify_api.config['MAX_CONTENT_LENGTH'] = max_content_length
|
||||||
|
large_name = "J" * (max_content_length or 1 + 1)
|
||||||
|
data = {
|
||||||
|
'email_address': 'ok@ok.com',
|
||||||
|
'template_id': str(sample_email_template_with_placeholders.id),
|
||||||
|
'personalisation': {
|
||||||
|
'name': large_name
|
||||||
|
}
|
||||||
|
}
|
||||||
|
with notify_api.test_client() as client:
|
||||||
|
response = client.post(
|
||||||
|
path=endpoint,
|
||||||
|
data=json.dumps(data),
|
||||||
|
headers=[('Content-Type', 'application/json')])
|
||||||
|
|
||||||
|
assert response.status_code == expected_status_code
|
||||||
Reference in New Issue
Block a user