darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-02 09:26:08 -05:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback remove british fake email addresses

Browse Source
This commit is contained in:
Kenneth Kehl
2023-08-16 07:19:18 -07:00
parent f2f0e5a0f1
commit 22f301189a
10 changed files with 47 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/app/user/test_rest.py
View File

@@ -113,7 +113,7 @@ def test_post_user(admin_request, notify_db_session):
User.query.delete()
data = {
"name": "Test User",
"email_address": "user@digital.cabinet-office.gov.uk",
"email_address": "user@digital.fake.gov",
"password": "password",
"mobile_number": "+12028675309",
"logged_in_at": None,
@@ -124,7 +124,7 @@ def test_post_user(admin_request, notify_db_session):
}
json_resp = admin_request.post('user.create_user', _data=data, _expected_status=201)
user = User.query.filter_by(email_address='user@digital.cabinet-office.gov.uk').first()
user = User.query.filter_by(email_address='user@digital.fake.gov').first()
assert user.check_password("password")
assert json_resp['data']['email_address'] == user.email_address
assert json_resp['data']['id'] == str(user.id)
@@ -135,7 +135,7 @@ def test_post_user_without_auth_type(admin_request, notify_db_session):
User.query.delete()
data = {
"name": "Test User",
"email_address": "user@digital.cabinet-office.gov.uk",
"email_address": "user@digital.fake.gov",
"password": "password",
"mobile_number": "+12028675309",
"permissions": {},
@@ -143,7 +143,7 @@ def test_post_user_without_auth_type(admin_request, notify_db_session):
json_resp = admin_request.post('user.create_user', _data=data, _expected_status=201)
user = User.query.filter_by(email_address='user@digital.cabinet-office.gov.uk').first()
user = User.query.filter_by(email_address='user@digital.fake.gov').first()
assert json_resp['data']['id'] == str(user.id)
assert user.auth_type == SMS_AUTH_TYPE
@@ -175,7 +175,7 @@ def test_create_user_missing_attribute_password(admin_request, notify_db_session
User.query.delete()
data = {
"name": "Test User",
"email_address": "user@digital.cabinet-office.gov.uk",
"email_address": "user@digital.fake.gov",
"mobile_number": "+12028675309",
"logged_in_at": None,
"state": "active",
@@ -190,7 +190,7 @@ def test_create_user_missing_attribute_password(admin_request, notify_db_session
def test_can_create_user_with_email_auth_and_no_mobile(admin_request, notify_db_session):
data = {
'name': 'Test User',
'email_address': 'user@digital.cabinet-office.gov.uk',
'email_address': 'user@digital.fake.gov',
'password': 'password',
'mobile_number': None,
'auth_type': EMAIL_AUTH_TYPE
@@ -205,7 +205,7 @@ def test_can_create_user_with_email_auth_and_no_mobile(admin_request, notify_db_
def test_cannot_create_user_with_sms_auth_and_no_mobile(admin_request, notify_db_session):
data = {
'name': 'Test User',
'email_address': 'user@digital.cabinet-office.gov.uk',
'email_address': 'user@digital.fake.gov',
'password': 'password',
'mobile_number': None,
'auth_type': SMS_AUTH_TYPE
@@ -272,7 +272,7 @@ def test_post_user_attribute(admin_request, sample_user, user_attribute, user_va
api_key_id=None, key_type='normal', notification_type='sms',
personalisation={
'name': 'Test User', 'servicemanagername': 'Service Manago',
'email address': 'notify@digital.cabinet-office.gov.uk'
'email address': 'notify@digital.fake.gov'
},
recipient='+4407700900460', reply_to_text='testing', service=mock.ANY,
template_id=uuid.UUID('8a31520f-4751-4789-8ea1-fe54496725eb'), template_version=1
@@ -282,7 +282,7 @@ def test_post_user_attribute_with_updated_by(
admin_request, mocker, sample_user, user_attribute,
user_value, arguments, team_member_email_edit_template, team_member_mobile_edit_template
):
updater = create_user(name="Service Manago", email="notify_manago@digital.cabinet-office.gov.uk")
updater = create_user(name="Service Manago", email="notify_manago@digital.fake.gov")
assert getattr(sample_user, user_attribute) != user_value
update_dict = {
user_attribute: user_value,
@@ -377,7 +377,7 @@ def test_get_user_by_email(admin_request, sample_service):
def test_get_user_by_email_not_found_returns_404(admin_request, sample_user):
json_resp = admin_request.get(
'user.get_by_email',
email='no_user@digital.gov.uk',
email='no_user@digital.fake.gov',
_expected_status=404
)
assert json_resp['result'] == 'error'
@@ -627,12 +627,12 @@ def test_send_user_reset_password_should_send_reset_password_link(admin_request,
@pytest.mark.parametrize('data, expected_url', (
({
'email': 'notify@digital.cabinet-office.gov.uk',
'email': 'notify@digital.fake.gov',
}, (
'http://localhost:6012/new-password/'
)),
({
'email': 'notify@digital.cabinet-office.gov.uk',
'email': 'notify@digital.fake.gov',
'admin_base_url': 'https://different.example.com',
}, (
'https://different.example.com/new-password/'