darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-09-02 17:48:36 -04:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback remove british fake email addresses

Browse Source
This commit is contained in:
Kenneth Kehl
2023-08-16 07:19:18 -07:00
parent f2f0e5a0f1
commit 22f301189a
10 changed files with 47 additions and 47 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/service/send_notification/test_send_notification.py
View File

@@ -925,7 +925,7 @@ def test_should_send_notification_to_guest_list_recipient(
@pytest.mark.parametrize(
'notification_type, template_type, to', [
(EMAIL_TYPE, SMS_TYPE, 'notify@digital.cabinet-office.gov.uk'),
(EMAIL_TYPE, SMS_TYPE, 'notify@digital.fake.gov'),
(SMS_TYPE, EMAIL_TYPE, '+12028675309')
])
def test_should_error_if_notification_type_does_not_match_template_type(
@@ -1177,7 +1177,7 @@ def test_should_not_allow_email_notifications_if_service_permission_not_set(
mocked = mocker.patch('app.celery.provider_tasks.deliver_email.apply_async')
data = {
'to': 'notify@digital.cabinet-office.gov.uk',
'to': 'notify@digital.fake.gov',
'template': str(sample_template_without_email_permission.id)
}

22
tests/app/service/test_rest.py
View File

@@ -192,7 +192,7 @@ def test_get_live_services_data(sample_user, admin_request):
assert response == [
{
'consent_to_research': None,
'contact_email': 'notify@digital.cabinet-office.gov.uk',
'contact_email': 'notify@digital.fake.gov',
'contact_mobile': '+12028675309',
'contact_name': 'Test User',
'email_totals': 1,
@@ -208,7 +208,7 @@ def test_get_live_services_data(sample_user, admin_request):
},
{
'consent_to_research': None,
'contact_email': 'notify@digital.cabinet-office.gov.uk',
'contact_email': 'notify@digital.fake.gov',
'contact_mobile': '+12028675309',
'contact_name': 'Test User',
'email_totals': 0,
@@ -417,7 +417,7 @@ def test_create_service_with_domain_sets_organization(
create_domain('test.gov.uk', org.id)
another_org = create_organization(name='Another')
create_domain('cabinet-office.gov.uk', another_org.id)
create_domain('fake.gov', another_org.id)
create_domain('cabinetoffice.gov.uk', another_org.id)
sample_user.email_address = 'test@{}'.format(domain)
@@ -1193,7 +1193,7 @@ def test_add_existing_user_to_another_service_with_all_permissions(
# add new user to service
user_to_add = User(
name='Invited User',
email_address='invited@digital.cabinet-office.gov.uk',
email_address='invited@digital.fake.gov',
password='password',
mobile_number='+4477123456'
)
@@ -1255,7 +1255,7 @@ def test_add_existing_user_to_another_service_with_send_permissions(notify_api,
# they must exist in db first
user_to_add = User(
name='Invited User',
email_address='invited@digital.cabinet-office.gov.uk',
email_address='invited@digital.fake.gov',
password='password',
mobile_number='+4477123456'
)
@@ -1301,7 +1301,7 @@ def test_add_existing_user_to_another_service_with_manage_permissions(notify_api
# they must exist in db first
user_to_add = User(
name='Invited User',
email_address='invited@digital.cabinet-office.gov.uk',
email_address='invited@digital.fake.gov',
password='password',
mobile_number='+4477123456'
)
@@ -1347,7 +1347,7 @@ def test_add_existing_user_to_another_service_with_folder_permissions(notify_api
# they must exist in db first
user_to_add = User(
name='Invited User',
email_address='invited@digital.cabinet-office.gov.uk',
email_address='invited@digital.fake.gov',
password='password',
mobile_number='+4477123456'
)
@@ -1387,7 +1387,7 @@ def test_add_existing_user_to_another_service_with_manage_api_keys(notify_api,
# they must exist in db first
user_to_add = User(
name='Invited User',
email_address='invited@digital.cabinet-office.gov.uk',
email_address='invited@digital.fake.gov',
password='password',
mobile_number='+4477123456'
)
@@ -1425,7 +1425,7 @@ def test_add_existing_user_to_non_existing_service_returns404(notify_api,
with notify_api.test_client() as client:
user_to_add = User(
name='Invited User',
email_address='invited@digital.cabinet-office.gov.uk',
email_address='invited@digital.fake.gov',
password='password',
mobile_number='+4477123456'
)
@@ -1497,7 +1497,7 @@ def test_add_unknown_user_to_service_returns404(notify_api, notify_db_session, s
def test_remove_user_from_service(
client, sample_user_service_permission
):
second_user = create_user(email="new@digital.cabinet-office.gov.uk")
second_user = create_user(email="new@digital.fake.gov")
service = sample_user_service_permission.service
# Simulates successfully adding a user to the service
@@ -1521,7 +1521,7 @@ def test_remove_user_from_service(
def test_remove_non_existant_user_from_service(
client, sample_user_service_permission
):
second_user = create_user(email="new@digital.cabinet-office.gov.uk")
second_user = create_user(email="new@digital.fake.gov")
endpoint = url_for(
'service.remove_user_from_service',
service_id=str(sample_user_service_permission.service.id),