darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 23:55:58 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #1376 from alphagov/remove-computed-sms-prefix

Browse Source 
Remove computed SMS prefix
This commit is contained in:
Chris Hill-Scott
2017-11-21 14:29:33 +00:00
committed by GitHub
parent ef9f18a175 ac885dd4e6
commit 22ec134668
3 changed files with 1 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
tests/app/service/test_rest.py
View File

@@ -158,7 +158,6 @@ def test_get_service_by_id(client, sample_service):
assert json_resp['data']['branding'] == 'govuk'
assert json_resp['data']['dvla_organisation'] == '001'
assert json_resp['data']['sms_sender'] == current_app.config['FROM_NUMBER']
assert json_resp['data']['prefix_sms_with_service_name'] is True
assert json_resp['data']['prefix_sms'] is True
@@ -1518,7 +1517,7 @@ def test_prefixing_messages_based_on_prefix_sms(
headers=[('Content-Type', 'application/json'), create_authorization_header()]
)
service = json.loads(result.get_data(as_text=True))['data']
assert service['prefix_sms_with_service_name'] == should_prefix
assert service['prefix_sms'] == should_prefix
@pytest.mark.parametrize('posted_value, stored_value, returned_value', [
@@ -1539,10 +1538,6 @@ def test_set_sms_prefixing_for_service(
_data={'prefix_sms': posted_value},
)
assert result['data']['prefix_sms'] == stored_value
# This derived value will go away eventually, once we’ve done a migration
assert result['data']['prefix_sms_with_service_name'] == returned_value
# The derived value is dependent on the service sending from the platform’s
# default from number
assert result['data']['sms_sender'] == current_app.config['FROM_NUMBER']