DRY-up recording the outcome of SMS sending

This reduces the code to copy when we add a new provider. I don't
think we need to log the URL or status code each time:

- The URL is always the same.
- A "200" status code is implicit in "success".
- Other status codes will be reported as exceptions.

Removing these specific elements means "record_outcome" is generic
and can be de-duplicated in the base class.
This commit is contained in:
Ben Thorner
2022-03-24 17:33:45 +00:00
parent 35f710bdf3
commit 22e055f4d1
3 changed files with 19 additions and 39 deletions

View File

@@ -18,6 +18,19 @@ class SmsClient(Client):
Base Sms client for sending smss.
'''
def record_outcome(self, success):
log_message = "Provider request for {} {}".format(
self.name,
"succeeded" if success else "failed",
)
if success:
self.current_app.logger.info(log_message)
self.statsd_client.incr(f"clients.{self.name}.success")
else:
self.statsd_client.incr(f"clients.{self.name}.error")
self.current_app.logger.warning(log_message)
def send_sms(self, *args, **kwargs):
raise NotImplementedError('TODO Need to implement.')