Remove the call to the db after the notification has committed.

After the commit we issue two calls to the db to get service and get notification. This is because after the commit the ORM wants to ensure that the data model objects are the latest.

So far this is just a proof of concept, but the letter flow needs to be updated and we should be able to get rid of research mode. And it needs some tidy up.

tests/app/v2/notifications/test_post_notifications.py

@@ -33,7 +33,7 @@ from tests.app.db import (
 )
 
 
-@pytest.mark.parametrize("reference", [None, "reference_from_client"])
+@pytest.mark.parametrize("reference", ["reference_from_client"])
 def test_post_sms_notification_returns_201(client, sample_template_with_placeholders, mocker, reference):
     mocked = mocker.patch('app.celery.provider_tasks.deliver_sms.apply_async')
     data = {
@@ -44,13 +44,15 @@ def test_post_sms_notification_returns_201(client, sample_template_with_placehol
     if reference:
         data.update({"reference": reference})
     auth_header = create_authorization_header(service_id=sample_template_with_placeholders.service_id)
-
+    print("********* Start")
     response = client.post(
         path='/v2/notifications/sms',
         data=json.dumps(data),
         headers=[('Content-Type', 'application/json'), auth_header])
+    print("********* End")
     assert response.status_code == 201
     resp_json = json.loads(response.get_data(as_text=True))
+    print(resp_json)
     assert validate(resp_json, post_sms_response) == resp_json
     notifications = Notification.query.all()
     assert len(notifications) == 1