From 213e612e315c16f54195066f4247b8583a6d5201 Mon Sep 17 00:00:00 2001 From: Kenneth Kehl <@kkehl@flexion.us> Date: Mon, 6 Oct 2025 08:26:00 -0700 Subject: [PATCH] fix tests --- tests/app/delivery/test_send_to_providers.py | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/tests/app/delivery/test_send_to_providers.py b/tests/app/delivery/test_send_to_providers.py index ac564f7e2..edba3e279 100644 --- a/tests/app/delivery/test_send_to_providers.py +++ b/tests/app/delivery/test_send_to_providers.py @@ -88,9 +88,15 @@ def test_should_send_personalised_template_to_correct_sms_provider_and_persist( reply_to_text=sample_sms_template_with_html.service.get_default_sms_sender(), ) - mock_client = MagicMock() - mock_client.send_sms.return_value = "reference" - send_mock = mocker.patch("app.aws_sns_client", mock_client) + mock_boto_client = mocker.patch("boto3.client") + mock_sns = MagicMock() + mock_boto_client.return_value = mock_sns + mock_sns.send_sms.return_value = "reference" + mock_sns.name = "sns" + mocker.patch( + "app.delivery.send_to_providers.provider_to_use", + return_value=mock_sns, + ) mock_s3 = mocker.patch("app.delivery.send_to_providers.get_phone_number_from_s3") mock_s3.return_value = "2028675309" @@ -103,7 +109,7 @@ def test_should_send_personalised_template_to_correct_sms_provider_and_persist( send_to_providers.send_sms_to_provider(db_notification) - send_mock.send_sms.assert_called_once_with( + mock_sns.send_sms.assert_called_once_with( to="2028675309", content="Sample service: Hello Jo\nHere is some HTML & entities", reference=str(db_notification.id),