darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-20 23:41:17 -05:00
Code Issues Packages Projects Releases Wiki Activity

Break down how long it takes to send a notification

Browse Source 
We currently measure the sending time for all. This commit then breaks
it down into
- test keys and non test keys
- high volume services and non high volume services

Breaking it down into test keys and non test keys is important because
we don't care as much about sending test notifications within 10
seconds, only non test keys so we don't want our graphs to reflect poor
performance if it's just test keys affecting this

Breaking it down into high volume and non high volume will allow us to
easily debug issues with slow sending if they are high volume or non
high volume issues
This commit is contained in:
David McDonald
2020-11-30 12:07:32 +00:00
parent 09a26ea4a9
commit 2110bc3eef
1 changed files with 20 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
app/delivery/send_to_providers.py
View File

@@ -76,6 +76,16 @@ def send_sms_to_provider(notification):
delta_seconds = (datetime.utcnow() - notification.created_at).total_seconds() delta_seconds = (datetime.utcnow() - notification.created_at).total_seconds()
statsd_client.timing("sms.total-time", delta_seconds) statsd_client.timing("sms.total-time", delta_seconds)
if notification.key_type == KEY_TYPE_TEST:
statsd_client.timing("sms.test-key.total-time", delta_seconds)
else:
statsd_client.timing("sms.live-key.total-time", delta_seconds)
if service.id in current_app.config.get('HIGH_VOLUME_SERVICE'):
statsd_client.timing("sms.high-volume.total-time", delta_seconds)
else:
statsd_client.timing("sms.not-high-volume.total-time", delta_seconds)
def send_email_to_provider(notification): def send_email_to_provider(notification):
service = notification.service service = notification.service
@@ -122,6 +132,16 @@ def send_email_to_provider(notification):
delta_seconds = (datetime.utcnow() - notification.created_at).total_seconds() delta_seconds = (datetime.utcnow() - notification.created_at).total_seconds()
statsd_client.timing("email.total-time", delta_seconds) statsd_client.timing("email.total-time", delta_seconds)
if notification.key_type == KEY_TYPE_TEST:
statsd_client.timing("email.test-key.total-time", delta_seconds)
else:
statsd_client.timing("email.live-key.total-time", delta_seconds)
if service.id in current_app.config.get('HIGH_VOLUME_SERVICE'):
statsd_client.timing("email.high-volume.total-time", delta_seconds)
else:
statsd_client.timing("email.not-high-volume.total-time", delta_seconds)
def update_notification_to_sending(notification, provider): def update_notification_to_sending(notification, provider):
notification.sent_at = datetime.utcnow() notification.sent_at = datetime.utcnow()