darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-31 15:15:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

Add endpoint to return all letter contact blocks

Browse Source 
Added the GET '/<uuid:service_id>/letter-contact' endpoint for returning
all letter contact blocks for a service.

Updated the DAO for service letter contacts to return the default letter
contact first.
This commit is contained in:
Katie Smith
2017-10-04 11:26:27 +01:00
parent 3ad0a43409
commit 1fa1ebb96f
4 changed files with 83 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

26
tests/app/dao/test_service_letter_contact_dao.py
View File

@@ -14,13 +14,15 @@ from tests.app.db import create_letter_contact, create_service
def test_dao_get_letter_contacts_by_service_id(notify_db_session):
service = create_service()
default_letter_contact = create_letter_contact(service=service, contact_block='Edinburgh, ED1 1AA')
another_letter_contact = create_letter_contact(service=service, contact_block='Cardiff, CA1 2DB')
second_letter_contact = create_letter_contact(service=service, contact_block='Cardiff, CA1 2DB', is_default=False)
third_letter_contact = create_letter_contact(service=service, contact_block='London, E1 8QS', is_default=False)
results = dao_get_letter_contacts_by_service_id(service_id=service.id)
assert len(results) == 2
assert default_letter_contact in results
assert another_letter_contact in results
assert len(results) == 3
assert default_letter_contact == results[0]
assert third_letter_contact == results[1]
assert second_letter_contact == results[2]
def test_create_or_update_letter_contact_creates_new_entry(notify_db_session):
@@ -105,11 +107,11 @@ def test_add_another_letter_contact_as_default_overrides_existing(notify_db_sess
assert len(results) == 2
assert results[0].contact_block == 'Edinburgh, ED1 1AA'
assert not results[0].is_default
assert results[0].contact_block == 'Swansea, SN1 3CC'
assert results[0].is_default
assert results[1].contact_block == 'Swansea, SN1 3CC'
assert results[1].is_default
assert results[1].contact_block == 'Edinburgh, ED1 1AA'
assert not results[1].is_default
def test_add_letter_contact_does_not_override_default(notify_db_session):
@@ -182,11 +184,11 @@ def test_update_letter_contact_as_default_overides_existing_default(notify_db_se
results = dao_get_letter_contacts_by_service_id(service_id=service.id)
assert len(results) == 2
assert results[0].contact_block == 'Aberdeen, AB12 23X'
assert not results[0].is_default
assert results[0].contact_block == 'Warwick, W14 TSR'
assert results[0].is_default
assert results[1].contact_block == 'Warwick, W14 TSR'
assert results[1].is_default
assert results[1].contact_block == 'Aberdeen, AB12 23X'
assert not results[1].is_default
def test_update_letter_contact_unset_default_for_only_letter_contact_raises_exception(notify_db_session):