darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-05-05 16:48:31 -04:00
Code Issues Packages Projects Releases Wiki Activity

reformat

Browse Source
This commit is contained in:
Kenneth Kehl
2023-08-29 14:54:30 -07:00
parent 19dcd7a48b
commit 1ecb747c6d
588 changed files with 34100 additions and 23589 deletions
Download Patch File Download Diff File Expand all files Collapse all files

273
tests/app/test_model.py
View File

@@ -37,54 +37,66 @@ from tests.app.db import (
)
@pytest.mark.parametrize('mobile_number', [
'+447700900855',
'+12348675309'
])
@pytest.mark.parametrize("mobile_number", ["+447700900855", "+12348675309"])
def test_should_build_service_guest_list_from_mobile_number(mobile_number):
service_guest_list = ServiceGuestList.from_string('service_id', MOBILE_TYPE, mobile_number)
service_guest_list = ServiceGuestList.from_string(
"service_id", MOBILE_TYPE, mobile_number
)
assert service_guest_list.recipient == mobile_number
@pytest.mark.parametrize('email_address', [
'test@example.com'
])
@pytest.mark.parametrize("email_address", ["test@example.com"])
def test_should_build_service_guest_list_from_email_address(email_address):
service_guest_list = ServiceGuestList.from_string('service_id', EMAIL_TYPE, email_address)
service_guest_list = ServiceGuestList.from_string(
"service_id", EMAIL_TYPE, email_address
)
assert service_guest_list.recipient == email_address
@pytest.mark.parametrize('contact, recipient_type', [
('', None),
('07700dsadsad', MOBILE_TYPE),
('gmail.com', EMAIL_TYPE)
])
def test_should_not_build_service_guest_list_from_invalid_contact(recipient_type, contact):
@pytest.mark.parametrize(
"contact, recipient_type",
[("", None), ("07700dsadsad", MOBILE_TYPE), ("gmail.com", EMAIL_TYPE)],
)
def test_should_not_build_service_guest_list_from_invalid_contact(
recipient_type, contact
):
with pytest.raises(ValueError):
ServiceGuestList.from_string('service_id', recipient_type, contact)
ServiceGuestList.from_string("service_id", recipient_type, contact)
@pytest.mark.parametrize('initial_statuses, expected_statuses', [
# passing in single statuses as strings
(NOTIFICATION_FAILED, NOTIFICATION_STATUS_TYPES_FAILED),
(NOTIFICATION_CREATED, [NOTIFICATION_CREATED]),
(NOTIFICATION_TECHNICAL_FAILURE, [NOTIFICATION_TECHNICAL_FAILURE]),
# passing in lists containing single statuses
([NOTIFICATION_FAILED], NOTIFICATION_STATUS_TYPES_FAILED),
([NOTIFICATION_CREATED], [NOTIFICATION_CREATED]),
([NOTIFICATION_TECHNICAL_FAILURE], [NOTIFICATION_TECHNICAL_FAILURE]),
# passing in lists containing multiple statuses
([NOTIFICATION_FAILED, NOTIFICATION_CREATED], NOTIFICATION_STATUS_TYPES_FAILED + [NOTIFICATION_CREATED]),
([NOTIFICATION_CREATED, NOTIFICATION_PENDING], [NOTIFICATION_CREATED, NOTIFICATION_PENDING]),
([NOTIFICATION_CREATED, NOTIFICATION_TECHNICAL_FAILURE], [NOTIFICATION_CREATED, NOTIFICATION_TECHNICAL_FAILURE]),
# checking we don't end up with duplicates
(
[NOTIFICATION_FAILED, NOTIFICATION_CREATED, NOTIFICATION_TECHNICAL_FAILURE],
NOTIFICATION_STATUS_TYPES_FAILED + [NOTIFICATION_CREATED]
),
])
@pytest.mark.parametrize(
"initial_statuses, expected_statuses",
[
# passing in single statuses as strings
(NOTIFICATION_FAILED, NOTIFICATION_STATUS_TYPES_FAILED),
(NOTIFICATION_CREATED, [NOTIFICATION_CREATED]),
(NOTIFICATION_TECHNICAL_FAILURE, [NOTIFICATION_TECHNICAL_FAILURE]),
# passing in lists containing single statuses
([NOTIFICATION_FAILED], NOTIFICATION_STATUS_TYPES_FAILED),
([NOTIFICATION_CREATED], [NOTIFICATION_CREATED]),
([NOTIFICATION_TECHNICAL_FAILURE], [NOTIFICATION_TECHNICAL_FAILURE]),
# passing in lists containing multiple statuses
(
[NOTIFICATION_FAILED, NOTIFICATION_CREATED],
NOTIFICATION_STATUS_TYPES_FAILED + [NOTIFICATION_CREATED],
),
(
[NOTIFICATION_CREATED, NOTIFICATION_PENDING],
[NOTIFICATION_CREATED, NOTIFICATION_PENDING],
),
(
[NOTIFICATION_CREATED, NOTIFICATION_TECHNICAL_FAILURE],
[NOTIFICATION_CREATED, NOTIFICATION_TECHNICAL_FAILURE],
),
# checking we don't end up with duplicates
(
[NOTIFICATION_FAILED, NOTIFICATION_CREATED, NOTIFICATION_TECHNICAL_FAILURE],
NOTIFICATION_STATUS_TYPES_FAILED + [NOTIFICATION_CREATED],
),
],
)
def test_status_conversion(initial_statuses, expected_statuses):
converted_statuses = Notification.substitute_status(initial_statuses)
assert len(converted_statuses) == len(expected_statuses)
@@ -92,47 +104,54 @@ def test_status_conversion(initial_statuses, expected_statuses):
@freeze_time("2016-01-01 11:09:00.000000")
@pytest.mark.parametrize('template_type, recipient', [
('sms', '+12028675309'),
('email', 'foo@bar.com'),
])
def test_notification_for_csv_returns_correct_type(sample_service, template_type, recipient):
@pytest.mark.parametrize(
"template_type, recipient",
[
("sms", "+12028675309"),
("email", "foo@bar.com"),
],
)
def test_notification_for_csv_returns_correct_type(
sample_service, template_type, recipient
):
template = create_template(sample_service, template_type=template_type)
notification = create_notification(template, to_field=recipient)
serialized = notification.serialize_for_csv()
assert serialized['template_type'] == template_type
assert serialized["template_type"] == template_type
@freeze_time("2016-01-01 11:09:00.000000")
def test_notification_for_csv_returns_correct_job_row_number(sample_job):
notification = create_notification(sample_job.template, sample_job, job_row_number=0)
notification = create_notification(
sample_job.template, sample_job, job_row_number=0
)
serialized = notification.serialize_for_csv()
assert serialized['row_number'] == 1
assert serialized["row_number"] == 1
@freeze_time("2016-01-30 12:39:58.321312")
@pytest.mark.parametrize('template_type, status, expected_status', [
('email', 'failed', 'Failed'),
('email', 'technical-failure', 'Technical failure'),
('email', 'temporary-failure', 'Inbox not accepting messages right now'),
('email', 'permanent-failure', 'Email address doesn’t exist'),
('sms', 'temporary-failure', 'Phone not accepting messages right now'),
('sms', 'permanent-failure', 'Phone number doesn’t exist'),
('sms', 'sent', 'Sent internationally'),
])
@pytest.mark.parametrize(
"template_type, status, expected_status",
[
("email", "failed", "Failed"),
("email", "technical-failure", "Technical failure"),
("email", "temporary-failure", "Inbox not accepting messages right now"),
("email", "permanent-failure", "Email address doesn’t exist"),
("sms", "temporary-failure", "Phone not accepting messages right now"),
("sms", "permanent-failure", "Phone number doesn’t exist"),
("sms", "sent", "Sent internationally"),
],
)
def test_notification_for_csv_returns_formatted_status(
sample_service,
template_type,
status,
expected_status
sample_service, template_type, status, expected_status
):
template = create_template(sample_service, template_type=template_type)
notification = create_notification(template, status=status)
serialized = notification.serialize_for_csv()
assert serialized['status'] == expected_status
assert serialized["status"] == expected_status
@freeze_time("2017-03-26 23:01:53.321312")
@@ -140,7 +159,7 @@ def test_notification_for_csv_returns_utc_correctly(sample_template):
notification = create_notification(sample_template)
serialized = notification.serialize_for_csv()
assert serialized['created_at'] == '2017-03-26 23:01:53'
assert serialized["created_at"] == "2017-03-26 23:01:53"
def test_notification_personalisation_getter_returns_empty_dict_from_none():
@@ -155,18 +174,19 @@ def test_notification_personalisation_getter_always_returns_empty_dict(notify_ap
assert noti.personalisation == {}
def test_notification_personalisation_getter_returns_empty_dict_for_encryption_errors(notify_app):
def test_notification_personalisation_getter_returns_empty_dict_for_encryption_errors(
notify_app,
):
noti = Notification()
# old _personalisation values were created with encryption.sign, which will trigger a decryption error
noti._personalisation = encryption.sign({"value": "PII"})
assert noti.personalisation == {}
@pytest.mark.parametrize('input_value', [
None,
{}
])
def test_notification_personalisation_setter_always_sets_empty_dict(notify_app, input_value):
@pytest.mark.parametrize("input_value", [None, {}])
def test_notification_personalisation_setter_always_sets_empty_dict(
notify_app, input_value
):
noti = Notification()
noti.personalisation = input_value
@@ -179,43 +199,51 @@ def test_notification_subject_is_none_for_sms(sample_service):
assert notification.subject is None
@pytest.mark.parametrize('template_type', ['email'])
@pytest.mark.parametrize("template_type", ["email"])
def test_notification_subject_fills_in_placeholders(sample_service, template_type):
template = create_template(service=sample_service, template_type=template_type, subject='((name))')
notification = create_notification(template=template, personalisation={'name': 'hello'})
assert notification.subject == 'hello'
template = create_template(
service=sample_service, template_type=template_type, subject="((name))"
)
notification = create_notification(
template=template, personalisation={"name": "hello"}
)
assert notification.subject == "hello"
def test_notification_serializes_created_by_name_with_no_created_by_id(client, sample_notification):
def test_notification_serializes_created_by_name_with_no_created_by_id(
client, sample_notification
):
res = sample_notification.serialize()
assert res['created_by_name'] is None
assert res["created_by_name"] is None
def test_notification_serializes_created_by_name_with_created_by_id(client, sample_notification, sample_user):
def test_notification_serializes_created_by_name_with_created_by_id(
client, sample_notification, sample_user
):
sample_notification.created_by_id = sample_user.id
res = sample_notification.serialize()
assert res['created_by_name'] == sample_user.name
assert res["created_by_name"] == sample_user.name
def test_sms_notification_serializes_without_subject(client, sample_template):
res = sample_template.serialize_for_v2()
assert res['subject'] is None
assert res["subject"] is None
def test_email_notification_serializes_with_subject(client, sample_email_template):
res = sample_email_template.serialize_for_v2()
assert res['subject'] == 'Email Subject'
assert res["subject"] == "Email Subject"
def test_notification_references_template_history(client, sample_template):
noti = create_notification(sample_template)
sample_template.version = 3
sample_template.content = 'New template content'
sample_template.content = "New template content"
res = noti.serialize()
assert res['template']['version'] == 1
assert res["template"]["version"] == 1
assert res['body'] == noti.template.content
assert res["body"] == noti.template.content
assert noti.template.content != sample_template.content
@@ -227,16 +255,21 @@ def test_notification_requires_a_valid_template_version(client, sample_template)
def test_inbound_number_serializes_with_service(client, notify_db_session):
service = create_service()
inbound_number = create_inbound_number(number='1', service_id=service.id)
inbound_number = create_inbound_number(number="1", service_id=service.id)
serialized_inbound_number = inbound_number.serialize()
assert serialized_inbound_number.get('id') == str(inbound_number.id)
assert serialized_inbound_number.get('service').get('id') == str(inbound_number.service.id)
assert serialized_inbound_number.get('service').get('name') == inbound_number.service.name
assert serialized_inbound_number.get("id") == str(inbound_number.id)
assert serialized_inbound_number.get("service").get("id") == str(
inbound_number.service.id
)
assert (
serialized_inbound_number.get("service").get("name")
== inbound_number.service.name
)
def test_inbound_number_returns_inbound_number(client, notify_db_session):
service = create_service()
inbound_number = create_inbound_number(number='1', service_id=service.id)
inbound_number = create_inbound_number(number="1", service_id=service.id)
assert service.get_inbound_number() == inbound_number.number
@@ -250,12 +283,12 @@ def test_inbound_number_returns_none_when_no_inbound_number(client, notify_db_se
def test_service_get_default_reply_to_email_address(sample_service):
create_reply_to_email(service=sample_service, email_address="default@email.com")
assert sample_service.get_default_reply_to_email_address() == 'default@email.com'
assert sample_service.get_default_reply_to_email_address() == "default@email.com"
def test_service_get_default_sms_sender(notify_db_session):
service = create_service()
assert service.get_default_sms_sender() == 'testing'
assert service.get_default_sms_sender() == "testing"
def test_template_folder_is_parent(sample_service):
@@ -272,18 +305,19 @@ def test_template_folder_is_parent(sample_service):
assert not folders[1].is_parent_of(folders[0])
@pytest.mark.parametrize('is_platform_admin', (False, True))
@pytest.mark.parametrize("is_platform_admin", (False, True))
def test_user_can_use_webauthn_if_platform_admin(sample_user, is_platform_admin):
sample_user.platform_admin = is_platform_admin
assert sample_user.can_use_webauthn == is_platform_admin
@pytest.mark.parametrize(('auth_type', 'can_use_webauthn'), [
('email_auth', False),
('sms_auth', False),
('webauthn_auth', True)
])
def test_user_can_use_webauthn_if_they_login_with_it(sample_user, auth_type, can_use_webauthn):
@pytest.mark.parametrize(
("auth_type", "can_use_webauthn"),
[("email_auth", False), ("sms_auth", False), ("webauthn_auth", True)],
)
def test_user_can_use_webauthn_if_they_login_with_it(
sample_user, auth_type, can_use_webauthn
):
sample_user.auth_type = auth_type
assert sample_user.can_use_webauthn == can_use_webauthn
@@ -292,12 +326,15 @@ def test_user_can_use_webauthn_if_in_notify_team(notify_service):
assert notify_service.users[0].can_use_webauthn
@pytest.mark.parametrize(('obj', 'return_val'), [
({'a': None}, {}),
({'b': 123}, {'b': 123}),
({'c': None, 'd': 456}, {'d': 456}),
({}, {})
])
@pytest.mark.parametrize(
("obj", "return_val"),
[
({"a": None}, {}),
({"b": 123}, {"b": 123}),
({"c": None, "d": 456}, {"d": 456}),
({}, {}),
],
)
def test_filter_null_value_fields(obj, return_val):
assert return_val == filter_null_value_fields(obj)
@@ -305,7 +342,7 @@ def test_filter_null_value_fields(obj, return_val):
def test_user_validate_mobile_number():
user = User()
with pytest.raises(ValueError):
user.validate_mobile_number('somekey', 'abcde')
user.validate_mobile_number("somekey", "abcde")
def test_user_password():
@@ -322,8 +359,15 @@ def test_annual_billing_serialize():
ab.created_at = now
serialized = ab.serialize()
print(serialized)
expected_keys = ['id', 'free_sms_fragment_limit', 'service_id', 'financial_year_start',
'created_at', 'updated_at', 'service']
expected_keys = [
"id",
"free_sms_fragment_limit",
"service_id",
"financial_year_start",
"created_at",
"updated_at",
"service",
]
for key in expected_keys:
assert key in serialized
serialized.pop(key)
@@ -331,14 +375,13 @@ def test_annual_billing_serialize():
def test_repr():
service = create_service()
sps = ServicePermission.query.all()
for sp in sps:
assert "has service permission" in sp.__repr__()
sgl = create_service_guest_list(service)
assert sgl.__repr__() == 'Recipient guest_list_user@digital.fake.gov of type: email'
assert sgl.__repr__() == "Recipient guest_list_user@digital.fake.gov of type: email"
def test_verify_code():
@@ -349,7 +392,9 @@ def test_verify_code():
def test_notification_get_created_by_email_address(sample_notification, sample_user):
sample_notification.created_by_id = sample_user.id
assert sample_notification.get_created_by_email_address() == 'notify@digital.fake.gov'
assert (
sample_notification.get_created_by_email_address() == "notify@digital.fake.gov"
)
def test_notification_history_from_original(sample_notification):
@@ -358,26 +403,26 @@ def test_notification_history_from_original(sample_notification):
def test_rate_str():
rate = create_rate('2023-01-01 00:00:00', 1.5, 'sms')
rate = create_rate("2023-01-01 00:00:00", 1.5, "sms")
assert rate.__str__() == '1.5 sms 2023-01-01 00:00:00'
assert rate.__str__() == "1.5 sms 2023-01-01 00:00:00"
def test_agreement_serialize():
agree = Agreement()
agree.id = 'abc'
agree.id = "abc"
now = datetime.utcnow()
agree.start_time = now
agree.end_time = now
serialize = agree.serialize()
serialize.pop('start_time')
serialize.pop('end_time')
serialize.pop("start_time")
serialize.pop("end_time")
assert serialize == {
'id': 'abc',
'type': None,
'partner_name': None,
'status': None,
'budget_amount': None,
'organization_id': None
"id": "abc",
"type": None,
"partner_name": None,
"status": None,
"budget_amount": None,
"organization_id": None,
}