This commit is contained in:
Kenneth Kehl
2023-08-29 14:54:30 -07:00
parent 19dcd7a48b
commit 1ecb747c6d
588 changed files with 34100 additions and 23589 deletions

View File

@@ -11,89 +11,91 @@ from tests.app.db import create_ft_notification_status, create_notification
# get_template_statistics_for_service_by_day
@pytest.mark.parametrize('query_string', [
{},
{'whole_days': -1},
{'whole_days': 8},
{'whole_days': 3.5},
{'whole_days': 'blurk'},
])
def test_get_template_statistics_for_service_by_day_with_bad_arg_returns_400(admin_request, query_string):
@pytest.mark.parametrize(
"query_string",
[
{},
{"whole_days": -1},
{"whole_days": 8},
{"whole_days": 3.5},
{"whole_days": "blurk"},
],
)
def test_get_template_statistics_for_service_by_day_with_bad_arg_returns_400(
admin_request, query_string
):
json_resp = admin_request.get(
'template_statistics.get_template_statistics_for_service_by_day',
"template_statistics.get_template_statistics_for_service_by_day",
service_id=uuid.uuid4(),
**query_string,
_expected_status=400
)
assert json_resp['result'] == 'error'
assert 'whole_days' in json_resp['message']
assert json_resp["result"] == "error"
assert "whole_days" in json_resp["message"]
def test_get_template_statistics_for_service_by_day_returns_template_info(admin_request, mocker, sample_notification):
json_resp = admin_request.get(
'template_statistics.get_template_statistics_for_service_by_day',
service_id=sample_notification.service_id,
whole_days=1
)
assert len(json_resp['data']) == 1
assert json_resp['data'][0]['count'] == 1
assert json_resp['data'][0]['template_id'] == str(sample_notification.template_id)
assert json_resp['data'][0]['template_name'] == 'sms Template Name'
assert json_resp['data'][0]['template_type'] == 'sms'
@pytest.mark.parametrize('var_name', ['limit_days', 'whole_days'])
def test_get_template_statistics_for_service_by_day_accepts_old_query_string(
admin_request,
mocker,
sample_notification,
var_name
def test_get_template_statistics_for_service_by_day_returns_template_info(
admin_request, mocker, sample_notification
):
json_resp = admin_request.get(
'template_statistics.get_template_statistics_for_service_by_day',
"template_statistics.get_template_statistics_for_service_by_day",
service_id=sample_notification.service_id,
whole_days=1,
)
assert len(json_resp["data"]) == 1
assert json_resp["data"][0]["count"] == 1
assert json_resp["data"][0]["template_id"] == str(sample_notification.template_id)
assert json_resp["data"][0]["template_name"] == "sms Template Name"
assert json_resp["data"][0]["template_type"] == "sms"
@pytest.mark.parametrize("var_name", ["limit_days", "whole_days"])
def test_get_template_statistics_for_service_by_day_accepts_old_query_string(
admin_request, mocker, sample_notification, var_name
):
json_resp = admin_request.get(
"template_statistics.get_template_statistics_for_service_by_day",
service_id=sample_notification.service_id,
**{var_name: 1}
)
assert len(json_resp['data']) == 1
assert len(json_resp["data"]) == 1
@freeze_time('2018-01-02 12:00:00')
@freeze_time("2018-01-02 12:00:00")
def test_get_template_statistics_for_service_by_day_goes_to_db(
admin_request,
mocker,
sample_template
admin_request, mocker, sample_template
):
# first time it is called redis returns data, second time returns none
mock_dao = mocker.patch(
'app.template_statistics.rest.fetch_notification_status_for_service_for_today_and_7_previous_days',
"app.template_statistics.rest.fetch_notification_status_for_service_for_today_and_7_previous_days",
return_value=[
Mock(
template_id=sample_template.id,
count=3,
template_name=sample_template.name,
notification_type=sample_template.template_type,
status='created'
status="created",
)
]
],
)
json_resp = admin_request.get(
'template_statistics.get_template_statistics_for_service_by_day',
"template_statistics.get_template_statistics_for_service_by_day",
service_id=sample_template.service_id,
whole_days=1
whole_days=1,
)
assert json_resp['data'] == [{
"template_id": str(sample_template.id),
"count": 3,
"template_name": sample_template.name,
"template_type": sample_template.template_type,
"status": "created"
}]
assert json_resp["data"] == [
{
"template_id": str(sample_template.id),
"count": 3,
"template_name": sample_template.name,
"template_type": sample_template.template_type,
"status": "created",
}
]
# dao only called for 2nd, since redis returned values for first call
mock_dao.assert_called_once_with(
str(sample_template.service_id), limit_days=1, by_template=True
@@ -101,59 +103,57 @@ def test_get_template_statistics_for_service_by_day_goes_to_db(
def test_get_template_statistics_for_service_by_day_returns_empty_list_if_no_templates(
admin_request,
mocker,
sample_service
admin_request, mocker, sample_service
):
json_resp = admin_request.get(
'template_statistics.get_template_statistics_for_service_by_day',
"template_statistics.get_template_statistics_for_service_by_day",
service_id=sample_service.id,
whole_days=7
whole_days=7,
)
assert len(json_resp['data']) == 0
assert len(json_resp["data"]) == 0
# get_last_used_datetime_for_template
def test_get_last_used_datetime_for_template(
admin_request, sample_template
):
def test_get_last_used_datetime_for_template(admin_request, sample_template):
date_from_notification = datetime.utcnow() - timedelta(hours=2)
create_notification(template=sample_template, created_at=date_from_notification)
date_from_ft_status = (datetime.utcnow() - timedelta(days=2)).date()
create_ft_notification_status(local_date=date_from_ft_status,
template=sample_template)
create_ft_notification_status(
local_date=date_from_ft_status, template=sample_template
)
json_resp = admin_request.get(
'template_statistics.get_last_used_datetime_for_template',
"template_statistics.get_last_used_datetime_for_template",
service_id=str(sample_template.service_id),
template_id=sample_template.id
template_id=sample_template.id,
)
assert json_resp["last_date_used"] == date_from_notification.strftime(
DATETIME_FORMAT
)
assert json_resp['last_date_used'] == date_from_notification.strftime(DATETIME_FORMAT)
def test_get_last_used_datetime_for_template_returns_none_if_no_usage_of_template(
admin_request, sample_template
):
json_resp = admin_request.get(
'template_statistics.get_last_used_datetime_for_template',
"template_statistics.get_last_used_datetime_for_template",
service_id=str(sample_template.service_id),
template_id=sample_template.id
template_id=sample_template.id,
)
assert json_resp['last_date_used'] is None
assert json_resp["last_date_used"] is None
def test_get_last_used_datetime_for_template_returns_400_if_service_does_not_exist(
admin_request, sample_template
):
admin_request.get(
'template_statistics.get_last_used_datetime_for_template',
"template_statistics.get_last_used_datetime_for_template",
service_id=uuid.uuid4(),
template_id=sample_template.id,
_expected_status=404
_expected_status=404,
)
@@ -161,8 +161,8 @@ def test_get_last_used_datetime_for_template_returns_404_if_template_does_not_ex
admin_request, sample_template
):
admin_request.get(
'template_statistics.get_last_used_datetime_for_template',
"template_statistics.get_last_used_datetime_for_template",
service_id=sample_template.service_id,
template_id=uuid.uuid4(),
_expected_status=404
_expected_status=404,
)