mirror of
https://github.com/GSA/notifications-api.git
synced 2026-05-05 16:48:31 -04:00
reformat
This commit is contained in:
@@ -22,23 +22,24 @@ from tests.app.db import (
|
||||
|
||||
@pytest.mark.parametrize("notification_type", ["email", "sms"])
|
||||
def test_send_delivery_status_to_service_post_https_request_to_service_with_encrypted_data(
|
||||
notify_db_session, notification_type):
|
||||
|
||||
notify_db_session, notification_type
|
||||
):
|
||||
callback_api, template = _set_up_test_data(notification_type, "delivery_status")
|
||||
datestr = datetime(2017, 6, 20)
|
||||
|
||||
notification = create_notification(template=template,
|
||||
created_at=datestr,
|
||||
updated_at=datestr,
|
||||
sent_at=datestr,
|
||||
status='sent'
|
||||
)
|
||||
notification = create_notification(
|
||||
template=template,
|
||||
created_at=datestr,
|
||||
updated_at=datestr,
|
||||
sent_at=datestr,
|
||||
status="sent",
|
||||
)
|
||||
encrypted_status_update = _set_up_data_for_status_update(callback_api, notification)
|
||||
with requests_mock.Mocker() as request_mock:
|
||||
request_mock.post(callback_api.url,
|
||||
json={},
|
||||
status_code=200)
|
||||
send_delivery_status_to_service(notification.id, encrypted_status_update=encrypted_status_update)
|
||||
request_mock.post(callback_api.url, json={}, status_code=200)
|
||||
send_delivery_status_to_service(
|
||||
notification.id, encrypted_status_update=encrypted_status_update
|
||||
)
|
||||
|
||||
mock_data = {
|
||||
"id": str(notification.id),
|
||||
@@ -50,28 +51,34 @@ def test_send_delivery_status_to_service_post_https_request_to_service_with_encr
|
||||
"sent_at": datestr.strftime(DATETIME_FORMAT),
|
||||
"notification_type": notification_type,
|
||||
"template_id": str(template.id),
|
||||
"template_version": 1
|
||||
"template_version": 1,
|
||||
}
|
||||
|
||||
assert request_mock.call_count == 1
|
||||
assert request_mock.request_history[0].url == callback_api.url
|
||||
assert request_mock.request_history[0].method == 'POST'
|
||||
assert request_mock.request_history[0].method == "POST"
|
||||
assert request_mock.request_history[0].text == json.dumps(mock_data)
|
||||
assert request_mock.request_history[0].headers["Content-type"] == "application/json"
|
||||
assert request_mock.request_history[0].headers["Authorization"] == "Bearer {}".format(callback_api.bearer_token)
|
||||
assert request_mock.request_history[0].headers[
|
||||
"Authorization"
|
||||
] == "Bearer {}".format(callback_api.bearer_token)
|
||||
|
||||
|
||||
def test_send_complaint_to_service_posts_https_request_to_service_with_encrypted_data(notify_db_session):
|
||||
with freeze_time('2001-01-01T12:00:00'):
|
||||
callback_api, template = _set_up_test_data('email', "complaint")
|
||||
def test_send_complaint_to_service_posts_https_request_to_service_with_encrypted_data(
|
||||
notify_db_session,
|
||||
):
|
||||
with freeze_time("2001-01-01T12:00:00"):
|
||||
callback_api, template = _set_up_test_data("email", "complaint")
|
||||
|
||||
notification = create_notification(template=template)
|
||||
complaint = create_complaint(service=template.service, notification=notification)
|
||||
complaint_data = _set_up_data_for_complaint(callback_api, complaint, notification)
|
||||
complaint = create_complaint(
|
||||
service=template.service, notification=notification
|
||||
)
|
||||
complaint_data = _set_up_data_for_complaint(
|
||||
callback_api, complaint, notification
|
||||
)
|
||||
with requests_mock.Mocker() as request_mock:
|
||||
request_mock.post(callback_api.url,
|
||||
json={},
|
||||
status_code=200)
|
||||
request_mock.post(callback_api.url, json={}, status_code=200)
|
||||
send_complaint_to_service(complaint_data)
|
||||
|
||||
mock_data = {
|
||||
@@ -79,99 +86,112 @@ def test_send_complaint_to_service_posts_https_request_to_service_with_encrypted
|
||||
"complaint_id": str(complaint.id),
|
||||
"reference": notification.client_reference,
|
||||
"to": notification.to,
|
||||
"complaint_date": datetime.utcnow().strftime(
|
||||
DATETIME_FORMAT),
|
||||
"complaint_date": datetime.utcnow().strftime(DATETIME_FORMAT),
|
||||
}
|
||||
|
||||
assert request_mock.call_count == 1
|
||||
assert request_mock.request_history[0].url == callback_api.url
|
||||
assert request_mock.request_history[0].method == 'POST'
|
||||
assert request_mock.request_history[0].method == "POST"
|
||||
assert request_mock.request_history[0].text == json.dumps(mock_data)
|
||||
assert request_mock.request_history[0].headers["Content-type"] == "application/json"
|
||||
assert request_mock.request_history[0].headers["Authorization"] == "Bearer {}".format(callback_api.bearer_token)
|
||||
assert (
|
||||
request_mock.request_history[0].headers["Content-type"]
|
||||
== "application/json"
|
||||
)
|
||||
assert request_mock.request_history[0].headers[
|
||||
"Authorization"
|
||||
] == "Bearer {}".format(callback_api.bearer_token)
|
||||
|
||||
|
||||
@pytest.mark.parametrize("notification_type", ["email", "sms"])
|
||||
@pytest.mark.parametrize('status_code', [429, 500, 503])
|
||||
@pytest.mark.parametrize("status_code", [429, 500, 503])
|
||||
def test__send_data_to_service_callback_api_retries_if_request_returns_error_code_with_encrypted_data(
|
||||
notify_db_session,
|
||||
mocker,
|
||||
notification_type,
|
||||
status_code
|
||||
notify_db_session, mocker, notification_type, status_code
|
||||
):
|
||||
callback_api, template = _set_up_test_data(notification_type, "delivery_status")
|
||||
datestr = datetime(2017, 6, 20)
|
||||
notification = create_notification(template=template,
|
||||
created_at=datestr,
|
||||
updated_at=datestr,
|
||||
sent_at=datestr,
|
||||
status='sent'
|
||||
)
|
||||
notification = create_notification(
|
||||
template=template,
|
||||
created_at=datestr,
|
||||
updated_at=datestr,
|
||||
sent_at=datestr,
|
||||
status="sent",
|
||||
)
|
||||
encrypted_data = _set_up_data_for_status_update(callback_api, notification)
|
||||
mocked = mocker.patch('app.celery.service_callback_tasks.send_delivery_status_to_service.retry')
|
||||
mocked = mocker.patch(
|
||||
"app.celery.service_callback_tasks.send_delivery_status_to_service.retry"
|
||||
)
|
||||
with requests_mock.Mocker() as request_mock:
|
||||
request_mock.post(callback_api.url,
|
||||
json={},
|
||||
status_code=status_code)
|
||||
send_delivery_status_to_service(notification.id, encrypted_status_update=encrypted_data)
|
||||
request_mock.post(callback_api.url, json={}, status_code=status_code)
|
||||
send_delivery_status_to_service(
|
||||
notification.id, encrypted_status_update=encrypted_data
|
||||
)
|
||||
|
||||
assert mocked.call_count == 1
|
||||
assert mocked.call_args[1]['queue'] == 'service-callbacks-retry'
|
||||
assert mocked.call_args[1]["queue"] == "service-callbacks-retry"
|
||||
|
||||
|
||||
@pytest.mark.parametrize("notification_type", ["email", "sms"])
|
||||
def test__send_data_to_service_callback_api_does_not_retry_if_request_returns_404_with_encrypted_data(
|
||||
notify_db_session,
|
||||
mocker,
|
||||
notification_type
|
||||
notify_db_session, mocker, notification_type
|
||||
):
|
||||
callback_api, template = _set_up_test_data(notification_type, "delivery_status")
|
||||
datestr = datetime(2017, 6, 20)
|
||||
notification = create_notification(template=template,
|
||||
created_at=datestr,
|
||||
updated_at=datestr,
|
||||
sent_at=datestr,
|
||||
status='sent'
|
||||
)
|
||||
notification = create_notification(
|
||||
template=template,
|
||||
created_at=datestr,
|
||||
updated_at=datestr,
|
||||
sent_at=datestr,
|
||||
status="sent",
|
||||
)
|
||||
encrypted_data = _set_up_data_for_status_update(callback_api, notification)
|
||||
mocked = mocker.patch('app.celery.service_callback_tasks.send_delivery_status_to_service.retry')
|
||||
mocked = mocker.patch(
|
||||
"app.celery.service_callback_tasks.send_delivery_status_to_service.retry"
|
||||
)
|
||||
with requests_mock.Mocker() as request_mock:
|
||||
request_mock.post(callback_api.url,
|
||||
json={},
|
||||
status_code=404)
|
||||
send_delivery_status_to_service(notification.id, encrypted_status_update=encrypted_data)
|
||||
request_mock.post(callback_api.url, json={}, status_code=404)
|
||||
send_delivery_status_to_service(
|
||||
notification.id, encrypted_status_update=encrypted_data
|
||||
)
|
||||
|
||||
assert mocked.call_count == 0
|
||||
|
||||
|
||||
def test_send_delivery_status_to_service_succeeds_if_sent_at_is_none(
|
||||
notify_db_session,
|
||||
mocker
|
||||
notify_db_session, mocker
|
||||
):
|
||||
callback_api, template = _set_up_test_data('email', "delivery_status")
|
||||
callback_api, template = _set_up_test_data("email", "delivery_status")
|
||||
datestr = datetime(2017, 6, 20)
|
||||
notification = create_notification(template=template,
|
||||
created_at=datestr,
|
||||
updated_at=datestr,
|
||||
sent_at=None,
|
||||
status='technical-failure'
|
||||
)
|
||||
notification = create_notification(
|
||||
template=template,
|
||||
created_at=datestr,
|
||||
updated_at=datestr,
|
||||
sent_at=None,
|
||||
status="technical-failure",
|
||||
)
|
||||
encrypted_data = _set_up_data_for_status_update(callback_api, notification)
|
||||
mocked = mocker.patch('app.celery.service_callback_tasks.send_delivery_status_to_service.retry')
|
||||
mocked = mocker.patch(
|
||||
"app.celery.service_callback_tasks.send_delivery_status_to_service.retry"
|
||||
)
|
||||
with requests_mock.Mocker() as request_mock:
|
||||
request_mock.post(callback_api.url,
|
||||
json={},
|
||||
status_code=404)
|
||||
send_delivery_status_to_service(notification.id, encrypted_status_update=encrypted_data)
|
||||
request_mock.post(callback_api.url, json={}, status_code=404)
|
||||
send_delivery_status_to_service(
|
||||
notification.id, encrypted_status_update=encrypted_data
|
||||
)
|
||||
|
||||
assert mocked.call_count == 0
|
||||
|
||||
|
||||
def _set_up_test_data(notification_type, callback_type):
|
||||
service = create_service(restricted=True)
|
||||
template = create_template(service=service, template_type=notification_type, subject='Hello')
|
||||
callback_api = create_service_callback_api(service=service, url="https://some.service.gov.uk/",
|
||||
bearer_token="something_unique", callback_type=callback_type)
|
||||
template = create_template(
|
||||
service=service, template_type=notification_type, subject="Hello"
|
||||
)
|
||||
callback_api = create_service_callback_api(
|
||||
service=service,
|
||||
url="https://some.service.gov.uk/",
|
||||
bearer_token="something_unique",
|
||||
callback_type=callback_type,
|
||||
)
|
||||
return callback_api, template
|
||||
|
||||
|
||||
@@ -182,9 +202,12 @@ def _set_up_data_for_status_update(callback_api, notification):
|
||||
"notification_to": notification.to,
|
||||
"notification_status": notification.status,
|
||||
"notification_created_at": notification.created_at.strftime(DATETIME_FORMAT),
|
||||
"notification_updated_at": notification.updated_at.strftime(
|
||||
DATETIME_FORMAT) if notification.updated_at else None,
|
||||
"notification_sent_at": notification.sent_at.strftime(DATETIME_FORMAT) if notification.sent_at else None,
|
||||
"notification_updated_at": notification.updated_at.strftime(DATETIME_FORMAT)
|
||||
if notification.updated_at
|
||||
else None,
|
||||
"notification_sent_at": notification.sent_at.strftime(DATETIME_FORMAT)
|
||||
if notification.sent_at
|
||||
else None,
|
||||
"notification_type": notification.notification_type,
|
||||
"service_callback_api_url": callback_api.url,
|
||||
"service_callback_api_bearer_token": callback_api.bearer_token,
|
||||
|
||||
Reference in New Issue
Block a user