darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2025-12-24 01:11:38 -05:00
Code Issues Packages Projects Releases Wiki Activity

reformat

Browse Source
This commit is contained in:
Kenneth Kehl
2023-08-29 14:54:30 -07:00
parent 19dcd7a48b
commit 1ecb747c6d
588 changed files with 34100 additions and 23589 deletions
Download Patch File Download Diff File Expand all files Collapse all files

183
tests/app/celery/test_provider_tasks.py
View File

@@ -15,41 +15,47 @@ from app.exceptions import NotificationTechnicalFailureException
def test_should_have_decorated_tasks_functions():
assert deliver_sms.__wrapped__.__name__ == 'deliver_sms'
assert deliver_email.__wrapped__.__name__ == 'deliver_email'
assert deliver_sms.__wrapped__.__name__ == "deliver_sms"
assert deliver_email.__wrapped__.__name__ == "deliver_email"
def test_should_call_send_sms_to_provider_from_deliver_sms_task(
sample_notification,
mocker):
mocker.patch('app.delivery.send_to_providers.send_sms_to_provider')
mocker.patch('app.celery.provider_tasks.check_sms_delivery_receipt')
sample_notification, mocker
):
mocker.patch("app.delivery.send_to_providers.send_sms_to_provider")
mocker.patch("app.celery.provider_tasks.check_sms_delivery_receipt")
deliver_sms(sample_notification.id)
app.delivery.send_to_providers.send_sms_to_provider.assert_called_with(sample_notification)
app.delivery.send_to_providers.send_sms_to_provider.assert_called_with(
sample_notification
)
def test_should_add_to_retry_queue_if_notification_not_found_in_deliver_sms_task(
notify_db_session,
mocker):
mocker.patch('app.delivery.send_to_providers.send_sms_to_provider')
mocker.patch('app.celery.provider_tasks.deliver_sms.retry')
notify_db_session, mocker
):
mocker.patch("app.delivery.send_to_providers.send_sms_to_provider")
mocker.patch("app.celery.provider_tasks.deliver_sms.retry")
notification_id = app.create_uuid()
deliver_sms(notification_id)
app.delivery.send_to_providers.send_sms_to_provider.assert_not_called()
app.celery.provider_tasks.deliver_sms.retry.assert_called_with(queue="retry-tasks", countdown=0)
app.celery.provider_tasks.deliver_sms.retry.assert_called_with(
queue="retry-tasks", countdown=0
)
def test_should_retry_and_log_warning_if_SmsClientResponseException_for_deliver_sms_task(sample_notification, mocker):
def test_should_retry_and_log_warning_if_SmsClientResponseException_for_deliver_sms_task(
sample_notification, mocker
):
mocker.patch(
'app.delivery.send_to_providers.send_sms_to_provider',
"app.delivery.send_to_providers.send_sms_to_provider",
side_effect=SmsClientResponseException("something went wrong"),
)
mocker.patch('app.celery.provider_tasks.deliver_sms.retry')
mock_logger_warning = mocker.patch('app.celery.tasks.current_app.logger.warning')
assert sample_notification.status == 'created'
mocker.patch("app.celery.provider_tasks.deliver_sms.retry")
mock_logger_warning = mocker.patch("app.celery.tasks.current_app.logger.warning")
assert sample_notification.status == "created"
deliver_sms(sample_notification.id)
@@ -60,29 +66,46 @@ def test_should_retry_and_log_warning_if_SmsClientResponseException_for_deliver_
def test_should_retry_and_log_exception_for_non_SmsClientResponseException_exceptions_for_deliver_sms_task(
sample_notification, mocker
):
mocker.patch('app.delivery.send_to_providers.send_sms_to_provider', side_effect=Exception("something went wrong"))
mocker.patch('app.celery.provider_tasks.deliver_sms.retry')
mock_logger_exception = mocker.patch('app.celery.tasks.current_app.logger.exception')
mocker.patch(
"app.delivery.send_to_providers.send_sms_to_provider",
side_effect=Exception("something went wrong"),
)
mocker.patch("app.celery.provider_tasks.deliver_sms.retry")
mock_logger_exception = mocker.patch(
"app.celery.tasks.current_app.logger.exception"
)
assert sample_notification.status == 'created'
assert sample_notification.status == "created"
deliver_sms(sample_notification.id)
assert provider_tasks.deliver_sms.retry.called is True
assert mock_logger_exception.called
def test_should_go_into_technical_error_if_exceeds_retries_on_deliver_sms_task(sample_notification, mocker):
mocker.patch('app.delivery.send_to_providers.send_sms_to_provider', side_effect=Exception("EXPECTED"))
mocker.patch('app.celery.provider_tasks.deliver_sms.retry', side_effect=MaxRetriesExceededError())
mock_logger_exception = mocker.patch('app.celery.tasks.current_app.logger.exception')
def test_should_go_into_technical_error_if_exceeds_retries_on_deliver_sms_task(
sample_notification, mocker
):
mocker.patch(
"app.delivery.send_to_providers.send_sms_to_provider",
side_effect=Exception("EXPECTED"),
)
mocker.patch(
"app.celery.provider_tasks.deliver_sms.retry",
side_effect=MaxRetriesExceededError(),
)
mock_logger_exception = mocker.patch(
"app.celery.tasks.current_app.logger.exception"
)
with pytest.raises(NotificationTechnicalFailureException) as e:
deliver_sms(sample_notification.id)
assert str(sample_notification.id) in str(e.value)
provider_tasks.deliver_sms.retry.assert_called_with(queue="retry-tasks", countdown=0)
provider_tasks.deliver_sms.retry.assert_called_with(
queue="retry-tasks", countdown=0
)
assert sample_notification.status == 'technical-failure'
assert sample_notification.status == "technical-failure"
assert mock_logger_exception.called
@@ -90,99 +113,125 @@ def test_should_go_into_technical_error_if_exceeds_retries_on_deliver_sms_task(s
def test_should_call_send_email_to_provider_from_deliver_email_task(
sample_notification,
mocker):
mocker.patch('app.delivery.send_to_providers.send_email_to_provider')
sample_notification, mocker
):
mocker.patch("app.delivery.send_to_providers.send_email_to_provider")
deliver_email(sample_notification.id)
app.delivery.send_to_providers.send_email_to_provider.assert_called_with(sample_notification)
app.delivery.send_to_providers.send_email_to_provider.assert_called_with(
sample_notification
)
def test_should_add_to_retry_queue_if_notification_not_found_in_deliver_email_task(mocker):
mocker.patch('app.delivery.send_to_providers.send_email_to_provider')
mocker.patch('app.celery.provider_tasks.deliver_email.retry')
def test_should_add_to_retry_queue_if_notification_not_found_in_deliver_email_task(
mocker,
):
mocker.patch("app.delivery.send_to_providers.send_email_to_provider")
mocker.patch("app.celery.provider_tasks.deliver_email.retry")
notification_id = app.create_uuid()
deliver_email(notification_id)
app.delivery.send_to_providers.send_email_to_provider.assert_not_called()
app.celery.provider_tasks.deliver_email.retry.assert_called_with(queue="retry-tasks")
app.celery.provider_tasks.deliver_email.retry.assert_called_with(
queue="retry-tasks"
)
@pytest.mark.parametrize(
'exception_class', [
"exception_class",
[
Exception(),
AwsSesClientException(),
AwsSesClientThrottlingSendRateException(),
]
],
)
def test_should_go_into_technical_error_if_exceeds_retries_on_deliver_email_task(
sample_notification, mocker, exception_class
):
mocker.patch('app.delivery.send_to_providers.send_email_to_provider', side_effect=exception_class)
mocker.patch('app.celery.provider_tasks.deliver_email.retry', side_effect=MaxRetriesExceededError())
mocker.patch(
"app.delivery.send_to_providers.send_email_to_provider",
side_effect=exception_class,
)
mocker.patch(
"app.celery.provider_tasks.deliver_email.retry",
side_effect=MaxRetriesExceededError(),
)
with pytest.raises(NotificationTechnicalFailureException) as e:
deliver_email(sample_notification.id)
assert str(sample_notification.id) in str(e.value)
provider_tasks.deliver_email.retry.assert_called_with(queue="retry-tasks")
assert sample_notification.status == 'technical-failure'
assert sample_notification.status == "technical-failure"
def test_should_technical_error_and_not_retry_if_EmailClientNonRetryableException(sample_notification, mocker):
def test_should_technical_error_and_not_retry_if_EmailClientNonRetryableException(
sample_notification, mocker
):
mocker.patch(
'app.delivery.send_to_providers.send_email_to_provider',
side_effect=EmailClientNonRetryableException('bad email')
"app.delivery.send_to_providers.send_email_to_provider",
side_effect=EmailClientNonRetryableException("bad email"),
)
mocker.patch('app.celery.provider_tasks.deliver_email.retry')
mocker.patch("app.celery.provider_tasks.deliver_email.retry")
deliver_email(sample_notification.id)
assert provider_tasks.deliver_email.retry.called is False
assert sample_notification.status == 'technical-failure'
assert sample_notification.status == "technical-failure"
def test_should_retry_and_log_exception_for_deliver_email_task(sample_notification, mocker):
def test_should_retry_and_log_exception_for_deliver_email_task(
sample_notification, mocker
):
error_response = {
'Error': {
'Code': 'SomeError',
'Message': 'some error message from amazon',
'Type': 'Sender'
"Error": {
"Code": "SomeError",
"Message": "some error message from amazon",
"Type": "Sender",
}
}
ex = ClientError(error_response=error_response, operation_name='opname')
mocker.patch('app.delivery.send_to_providers.send_email_to_provider', side_effect=AwsSesClientException(str(ex)))
mocker.patch('app.celery.provider_tasks.deliver_email.retry')
mock_logger_exception = mocker.patch('app.celery.tasks.current_app.logger.exception')
ex = ClientError(error_response=error_response, operation_name="opname")
mocker.patch(
"app.delivery.send_to_providers.send_email_to_provider",
side_effect=AwsSesClientException(str(ex)),
)
mocker.patch("app.celery.provider_tasks.deliver_email.retry")
mock_logger_exception = mocker.patch(
"app.celery.tasks.current_app.logger.exception"
)
deliver_email(sample_notification.id)
assert provider_tasks.deliver_email.retry.called is True
assert sample_notification.status == 'created'
assert sample_notification.status == "created"
assert mock_logger_exception.called
def test_if_ses_send_rate_throttle_then_should_retry_and_log_warning(sample_notification, mocker):
def test_if_ses_send_rate_throttle_then_should_retry_and_log_warning(
sample_notification, mocker
):
error_response = {
'Error': {
'Code': 'Throttling',
'Message': 'Maximum sending rate exceeded.',
'Type': 'Sender'
"Error": {
"Code": "Throttling",
"Message": "Maximum sending rate exceeded.",
"Type": "Sender",
}
}
ex = ClientError(error_response=error_response, operation_name='opname')
ex = ClientError(error_response=error_response, operation_name="opname")
mocker.patch(
'app.delivery.send_to_providers.send_email_to_provider',
side_effect=AwsSesClientThrottlingSendRateException(str(ex))
"app.delivery.send_to_providers.send_email_to_provider",
side_effect=AwsSesClientThrottlingSendRateException(str(ex)),
)
mocker.patch("app.celery.provider_tasks.deliver_email.retry")
mock_logger_warning = mocker.patch("app.celery.tasks.current_app.logger.warning")
mock_logger_exception = mocker.patch(
"app.celery.tasks.current_app.logger.exception"
)
mocker.patch('app.celery.provider_tasks.deliver_email.retry')
mock_logger_warning = mocker.patch('app.celery.tasks.current_app.logger.warning')
mock_logger_exception = mocker.patch('app.celery.tasks.current_app.logger.exception')
deliver_email(sample_notification.id)
assert provider_tasks.deliver_email.retry.called is True
assert sample_notification.status == 'created'
assert sample_notification.status == "created"
assert not mock_logger_exception.called
assert mock_logger_warning.called