darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-30 06:21:50 -05:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2551 from alphagov/fix-0-billable-units

Browse Source 
Fix 0 billable units on provider callback
This commit is contained in:
Katie Smith
2019-07-02 09:12:55 +01:00
committed by GitHub
parent 5093b68f94 4f7cde3452
commit 1ebd147ad0
2 changed files with 26 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
tests/app/notifications/test_process_client_response.py
View File

@@ -96,7 +96,7 @@ def test_process_sms_response_does_not_send_status_update_for_pending(sample_not
send_mock.assert_not_called()
def test_process_sms_updates_sent_by_with_client_name_if_not_in_noti(notify_db, sample_notification):
def test_process_sms_updates_sent_by_with_client_name_if_not_in_noti(sample_notification):
sample_notification.sent_by = None
success, error = process_sms_client_response(
status='3', provider_reference=str(sample_notification.id), client_name='MMG')
@@ -105,7 +105,16 @@ def test_process_sms_updates_sent_by_with_client_name_if_not_in_noti(notify_db,
assert sample_notification.sent_by == 'mmg'
def test_process_sms_does_not_update_sent_by_if_already_set(mocker, notify_db, sample_notification):
def test_process_sms_updates_billable_units_if_zero(sample_notification):
sample_notification.billable_units = 0
success, error = process_sms_client_response(
status='3', provider_reference=str(sample_notification.id), client_name='MMG')
assert error is None
assert success == 'MMG callback succeeded. reference {} updated'.format(sample_notification.id)
assert sample_notification.billable_units == 1
def test_process_sms_does_not_update_sent_by_if_already_set(mocker, sample_notification):
mock_update = mocker.patch('app.notifications.process_client_response.set_notification_sent_by')
sample_notification.sent_by = 'MMG'
process_sms_client_response(