darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-02-01 15:46:07 -05:00
Code Issues Packages Projects Releases Wiki Activity

Refactor code to make it clearer

Browse Source 
- Added code in `delete_notifications_created_more_than_a_week_ago_by_type` to remove notifications to email_reply_to older than 7 days
- Added transactional to `delete_notifications_created_more_than_a_week_ago_by_type`
This commit is contained in:
Ken Tsang
2017-10-11 12:26:58 +01:00
parent b77a606699
commit 1eaf6e089b
4 changed files with 15 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/app/dao/notification_dao/test_notification_dao.py
View File

@@ -41,7 +41,6 @@ from app.dao.notifications_dao import (
dao_update_notification,
dao_update_notifications_for_job_to_sent_to_dvla,
delete_notifications_created_more_than_a_week_ago_by_type,
delete_notification_to_email_reply_to_more_than_a_week_ago,
get_notification_by_id,
get_notification_for_job,
get_notification_with_personalisation,
@@ -1027,7 +1026,6 @@ def test_should_delete_notification_to_email_reply_to_after_seven_days(
assert len(all_notification_email_reply_to) == 10
# Records before 3rd should be deleted
delete_notification_to_email_reply_to_more_than_a_week_ago()
delete_notifications_created_more_than_a_week_ago_by_type(EMAIL_TYPE)
remaining_email_notifications = Notification.query.filter_by(notification_type=EMAIL_TYPE).all()
remaining_notification_to_email_reply_to = NotificationEmailReplyTo.query.filter_by().all()