Refactor code to make it clearer

- Added code in `delete_notifications_created_more_than_a_week_ago_by_type` to remove notifications to email_reply_to older than 7 days
- Added transactional to `delete_notifications_created_more_than_a_week_ago_by_type`
This commit is contained in:
Ken Tsang
2017-10-11 12:26:58 +01:00
parent b77a606699
commit 1eaf6e089b
4 changed files with 15 additions and 35 deletions

View File

@@ -126,12 +126,9 @@ def test_should_call_delete_sms_notifications_more_than_week_in_task(notify_api,
def test_should_call_delete_email_notifications_more_than_week_in_task(notify_api, mocker):
mocked_delete_noti_to_reply_to = mocker.patch(
'app.celery.scheduled_tasks.delete_notification_to_email_reply_to_more_than_a_week_ago')
mocked_notifications = mocker.patch(
'app.celery.scheduled_tasks.delete_notifications_created_more_than_a_week_ago_by_type')
delete_email_notifications_older_than_seven_days()
mocked_delete_noti_to_reply_to.assert_called_once_with()
mocked_notifications.assert_called_once_with('email')