darkhelm/notifications-api
1
0
Fork 0
mirror of https://github.com/GSA/notifications-api.git synced 2026-01-29 22:11:52 -05:00
Code Issues Packages Projects Releases Wiki Activity

code review feedback

Browse Source
This commit is contained in:
Kenneth Kehl
2023-05-09 08:45:51 -07:00
parent 2d6d7902a1
commit 1e72f97b17
3 changed files with 19 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
tests/app/clients/test_aws_cloudwatch.py
View File

@@ -58,7 +58,7 @@ def test_check_sms_success(notify_api, mocker):
message_id = 'succeed'
notification_id = 'ccc'
with notify_api.app_context():
aws_cloudwatch_client.check_sms(message_id, notification_id)
aws_cloudwatch_client.check_sms(message_id, notification_id, 1000000000000)
# We check the 'success' log group first and if we find the message_id, we are done, so there is only 1 call
assert boto_mock.filter_log_events.call_count == 1
@@ -77,7 +77,7 @@ def test_check_sms_failure(notify_api, mocker):
message_id = 'fail'
notification_id = 'bbb'
with notify_api.app_context():
aws_cloudwatch_client.check_sms(message_id, notification_id)
aws_cloudwatch_client.check_sms(message_id, notification_id, 1000000000000)
# We check the 'success' log group and find nothing, so we then check the 'fail' log group -- two calls.
assert boto_mock.filter_log_events.call_count == 2