From 1e537d507b28812138df6c87eeb6c2a921f26cf4 Mon Sep 17 00:00:00 2001
From: David McDonald <david.mcdonald@digital.cabinet-office.gov.uk>
Date: Mon, 11 Jan 2021 13:37:45 +0000
Subject: [PATCH] Make lambda_name abstract property

As we require all instances to have it
---
 app/clients/cbc_proxy.py | 11 ++++-------
 1 file changed, 4 insertions(+), 7 deletions(-)

diff --git a/app/clients/cbc_proxy.py b/app/clients/cbc_proxy.py
index 3d3abb3f5..df308a6d8 100644
--- a/app/clients/cbc_proxy.py
+++ b/app/clients/cbc_proxy.py
@@ -51,7 +51,10 @@ class CBCProxyClient:
 
 
 class CBCProxyClientBase(ABC):
-    lambda_name = None
+    @property
+    @abstractmethod
+    def lambda_name(self):
+        pass
 
     @property
     @abstractmethod
@@ -101,12 +104,6 @@ class CBCProxyClientBase(ABC):
         pass
 
     def _invoke_lambda_with_failover(self, payload):
-        if not self.lambda_name:
-            current_app.logger.warning(
-                '{self.__class__.__name__} tried to send {payload} but cbc proxy aws env vars not set'
-            )
-            return
-
         payload_bytes = bytes(json.dumps(payload), encoding='utf8')
         result = self._invoke_lambda(self.lambda_name, payload_bytes)